[gnome-online-accounts/maybe-fix-kcm-issue] identity: Don't add temporary accounts for expired credentials




commit ff5926652a739b61db2810d46ae3afa0927665d9
Author: Ray Strode <rstrode redhat com>
Date:   Thu Oct 13 16:11:54 2022 -0400

    identity: Don't add temporary accounts for expired credentials
    
    The identity service creates a "temporary" kerberos account when
    a user manually does kinit, to handle automatic renewal, etc.
    
    Unfortunately, it also picks up expired cruft that builds up in
    KCM based credential caches, and creates temporary accounts for
    that as well.
    
    This commit tries to avoid that.
    
    Closes https://gitlab.gnome.org/GNOME/gnome-online-accounts/-/issues/32

 src/goaidentity/goaidentityservice.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/goaidentity/goaidentityservice.c b/src/goaidentity/goaidentityservice.c
index 3dd27060..a25de416 100644
--- a/src/goaidentity/goaidentityservice.c
+++ b/src/goaidentity/goaidentityservice.c
@@ -1097,7 +1097,7 @@ on_identity_added (GoaIdentityManager *identity_manager,
 
   object = find_object_with_principal (self, identifier, FALSE);
 
-  if (object == NULL)
+  if (object == NULL && goa_identity_is_signed_in (identity))
     add_temporary_account (self, identity);
 
   g_clear_object (&object);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]