[gnome-software/1930-app-page-broken-ratings-card-empty-state: 16/16] gs-details-page: Hide review histogram part when it's empty
- From: Milan Crha <mcrha src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software/1930-app-page-broken-ratings-card-empty-state: 16/16] gs-details-page: Hide review histogram part when it's empty
- Date: Tue, 11 Oct 2022 05:49:02 +0000 (UTC)
commit 15a81ae39153ea7344599c9a7de258ab77a82e9c
Author: Milan Crha <mcrha redhat com>
Date: Thu Sep 29 12:29:28 2022 +0200
gs-details-page: Hide review histogram part when it's empty
When the review histogram part is empty, which can happen when no ratings
are downloaded and there's no review button to be shown, the corresponding
listbox was empty, causing and odd view on the reviews part.
Closes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1930
src/gs-details-page.c | 8 +++++---
src/gs-details-page.ui | 1 -
2 files changed, 5 insertions(+), 4 deletions(-)
---
diff --git a/src/gs-details-page.c b/src/gs-details-page.c
index 50b80e159..b1839ae03 100644
--- a/src/gs-details-page.c
+++ b/src/gs-details-page.c
@@ -1573,11 +1573,13 @@ gs_details_page_refresh_reviews (GsDetailsPage *self)
gtk_widget_set_visible (self->list_box_featured_review, reviews->len > 0);
/* Update the overall container. */
- gtk_widget_set_visible (self->box_reviews,
+ gtk_widget_set_visible (self->list_box_reviews_summary,
show_reviews &&
(gtk_widget_get_visible (self->histogram_row) ||
- gtk_widget_get_visible (self->button_review) ||
- reviews->len > 0));
+ gtk_widget_get_visible (self->button_review)));
+ gtk_widget_set_visible (self->box_reviews,
+ reviews->len > 0 ||
+ gtk_widget_get_visible (self->list_box_reviews_summary));
}
static void
diff --git a/src/gs-details-page.ui b/src/gs-details-page.ui
index 6e12e0a1b..d3fad10a4 100644
--- a/src/gs-details-page.ui
+++ b/src/gs-details-page.ui
@@ -868,7 +868,6 @@
<property name="can_focus">True</property>
<property name="selection_mode">none</property>
<property name="valign">start</property>
- <property name="visible" bind-source="histogram"
bind-property="visible" bind-flags="sync-create"/>
<style>
<class name="boxed-list"/>
</style>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]