[gnome-software: 1/2] gs-plugin-job-list-apps: Filter out invalid apps
- From: Milan Crha <mcrha src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software: 1/2] gs-plugin-job-list-apps: Filter out invalid apps
- Date: Mon, 3 Oct 2022 06:45:21 +0000 (UTC)
commit 79515873a275fff8f3f0713fb232e463358865bf
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date: Thu Sep 29 10:18:22 2022 -0300
gs-plugin-job-list-apps: Filter out invalid apps
This filtering was lost with 7d54958d4e46e27af2cbdfc7f529611f4709d7fe.
Filter out invalid apps as it did before.
Closes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1932
lib/gs-plugin-job-list-apps.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
---
diff --git a/lib/gs-plugin-job-list-apps.c b/lib/gs-plugin-job-list-apps.c
index 811c7c08f..a556387e5 100644
--- a/lib/gs-plugin-job-list-apps.c
+++ b/lib/gs-plugin-job-list-apps.c
@@ -136,6 +136,19 @@ gs_plugin_job_list_apps_set_property (GObject *object,
}
}
+static gboolean
+filter_valid_apps (GsApp *app,
+ gpointer user_data)
+{
+ GsPluginJobListApps *self = GS_PLUGIN_JOB_LIST_APPS (user_data);
+ GsPluginRefineFlags refine_flags = GS_PLUGIN_REFINE_FLAGS_NONE;
+
+ if (self->query)
+ refine_flags = gs_app_query_get_refine_flags (self->query);
+
+ return gs_plugin_loader_app_is_valid (app, refine_flags);
+}
+
static gboolean
app_filter_qt_for_gtk_and_compatible (GsApp *app,
gpointer user_data)
@@ -345,6 +358,7 @@ finish_task (GTask *task,
/* Standard filtering.
*
* FIXME: It feels like this filter should be done in a different layer. */
+ gs_app_list_filter (merged_list, filter_valid_apps, self);
gs_app_list_filter (merged_list, app_filter_qt_for_gtk_and_compatible, plugin_loader);
/* Caller-specified filtering. */
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]