[shotwell/wip/gtk4: 15/88] Fix BasicProperties display

[Jens Georg <jensgeorg src gnome org>]

commit e58e15dc560e9810b1cb6c1e02da2bf28249cee6
Author: Jens Georg <mail jensge org>
Date:   Sun Apr 3 21:00:55 2022 +0200

    Fix BasicProperties display

 src/Properties.vala            | 8 ++++++--
 src/library/LibraryWindow.vala | 5 ++---
 2 files changed, 8 insertions(+), 5 deletions(-)
---
diff --git a/src/Properties.vala b/src/Properties.vala
index a29f1892..b4625a0f 100644
--- a/src/Properties.vala
+++ b/src/Properties.vala
@@ -143,8 +143,12 @@ private abstract class Properties : Gtk.Box {
     }
 
     protected virtual void clear_properties() {
-        //foreach (Gtk.Widget child in grid.get_children())
-        //    grid.remove(child);
+        var iter = grid.get_first_child ();
+        while (iter != null) {
+            var next = iter.get_next_sibling ();
+            grid.remove (iter);
+            iter = next;
+        }
 
         line_count = 0;
     }
diff --git a/src/library/LibraryWindow.vala b/src/library/LibraryWindow.vala
index e7d2cffc..ca022e10 100644
--- a/src/library/LibraryWindow.vala
+++ b/src/library/LibraryWindow.vala
@@ -344,7 +344,7 @@ public class LibraryWindow : AppWindow {
 
         var basic_properties_action = get_current_page ().get_common_action
             ("CommonDisplayBasicProperties");
-        //assert(basic_properties_action != null);
+        assert(basic_properties_action != null);
 
         if (!basic_properties_action.get_state().get_boolean())
             bottom_frame.hide();
@@ -1081,7 +1081,6 @@ public class LibraryWindow : AppWindow {
         basic_properties.halign = Gtk.Align.FILL;
         basic_properties.valign = Gtk.Align.CENTER;
         basic_properties.hexpand = true;
-        basic_properties.vexpand = true;
         basic_properties.margin_top = 10;
         basic_properties.margin_bottom = 10;
         basic_properties.margin_start = 6;
@@ -1097,7 +1096,7 @@ public class LibraryWindow : AppWindow {
 
         sidebar_paned.set_start_child(top_section);
         sidebar_paned.set_end_child(bottom_frame);
-        sidebar_paned.set_position(1000);
+        sidebar_paned.set_position(700);
         
         right_vbox = new Gtk.Box(Gtk.Orientation.VERTICAL, 0);
         right_vbox.append(search_toolbar);