[gupnp] all: Fix minor issues from scan-build



commit dbbc405ec18d018a0ac45cb7f98774ad1e886166
Author: Jens Georg <mail jensge org>
Date:   Thu May 26 01:36:36 2022 +0200

    all: Fix minor issues from scan-build

 libgupnp/gupnp-resource-factory.c | 6 +++---
 tests/test-bugs.c                 | 1 -
 2 files changed, 3 insertions(+), 4 deletions(-)
---
diff --git a/libgupnp/gupnp-resource-factory.c b/libgupnp/gupnp-resource-factory.c
index b651f91..3dbfdcf 100644
--- a/libgupnp/gupnp-resource-factory.c
+++ b/libgupnp/gupnp-resource-factory.c
@@ -264,7 +264,7 @@ gupnp_resource_factory_create_service_proxy (GUPnPResourceFactory *factory,
                                              const GUri *url_base)
 {
         GUPnPServiceProxy *proxy;
-        GType              proxy_type = GUPNP_TYPE_SERVICE_PROXY;
+        GType proxy_type;
         GUPnPResourceFactoryPrivate *priv;
 
         g_return_val_if_fail (GUPNP_IS_RESOURCE_FACTORY (factory), NULL);
@@ -320,7 +320,7 @@ gupnp_resource_factory_create_device (GUPnPResourceFactory *factory,
                                       const GUri *url_base)
 {
         GUPnPDevice *device;
-        GType        device_type = GUPNP_TYPE_DEVICE;
+        GType device_type;
         GUPnPResourceFactoryPrivate *priv;
 
         g_return_val_if_fail (GUPNP_IS_RESOURCE_FACTORY (factory), NULL);
@@ -386,7 +386,7 @@ gupnp_resource_factory_create_service (GUPnPResourceFactory *factory,
                                        const GUri *url_base)
 {
         GUPnPService *service;
-        GType         service_type = GUPNP_TYPE_SERVICE;
+        GType service_type;
         GUPnPResourceFactoryPrivate *priv;
 
         g_return_val_if_fail (GUPNP_IS_RESOURCE_FACTORY (factory), NULL);
diff --git a/tests/test-bugs.c b/tests/test-bugs.c
index 2bc67f5..8debeab 100644
--- a/tests/test-bugs.c
+++ b/tests/test-bugs.c
@@ -89,7 +89,6 @@ test_bgo_696762_on_browse_call (G_GNUC_UNUSED GUPnPService *service,
 
     g_assert (node != NULL);
     g_assert_cmpstr ((const char *) node->name, ==, "SortCriteria");
-    node = node->next;
     gupnp_service_action_return_success (action);
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]