[seahorse/nielsdg/meson: 2/3] meson: Make sure run_command propagates failure




commit d4595fe905aac151ead055272e977c0c5eed12c4
Author: Niels De Graef <nielsdegraef gmail com>
Date:   Tue May 24 09:35:55 2022 +0200

    meson: Make sure run_command propagates failure
    
    Apparent, `run_command()` doesn't check whether the command failed or
    not, and just silently moves on if it did. Meson warns us about this
    behavior, so let's follow common sense here.

 meson.build | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
---
diff --git a/meson.build b/meson.build
index 1099d50e..e1e55b13 100644
--- a/meson.build
+++ b/meson.build
@@ -50,7 +50,10 @@ gpg_bin = find_program('gpg2', 'gpg', required: get_option('pgp-support'))
 gpgme_dep = dependency('gpgme', version: '>= 1.14.0', required: get_option('pgp-support'))
 
 if get_option('pgp-support')
-  gpg_version_check = run_command([gpg_check_version, gpg_bin.full_path(), accepted_gpg_versions ])
+  gpg_version_check = run_command(
+    [gpg_check_version, gpg_bin.full_path(), accepted_gpg_versions ],
+    check: true,
+  )
   # GnuPG now outputs e.g. 2.3.4-unknown so we need to drop this extra cruft
   gpg_version_raw = gpg_version_check.stdout()
   gpg_version_raw_split = gpg_version_raw.split('-')


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]