[glib/gobject-speedups: 11/18] Don't copy values during g_object_set




commit 54c4ef6e1f7f947cf2d3451e598ef5524bbad8cc
Author: Matthias Clasen <mclasen redhat com>
Date:   Sun May 15 07:55:22 2022 -0400

    Don't copy values during g_object_set
    
    It is safe not to copy arguments when we are
    setting properties. This matches what we do
    for g_object_new now.

 gobject/gobject.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
---
diff --git a/gobject/gobject.c b/gobject/gobject.c
index b49114be55..39d5edca17 100644
--- a/gobject/gobject.c
+++ b/gobject/gobject.c
@@ -2555,8 +2555,7 @@ g_object_set_valist (GObject       *object,
       if (!g_object_set_is_valid_property (object, pspec, name))
         break;
 
-      G_VALUE_COLLECT_INIT (&value, pspec->value_type, var_args,
-                           0, &error);
+      G_VALUE_COLLECT_INIT (&value, pspec->value_type, var_args, G_VALUE_NOCOPY_CONTENTS, &error);
       if (error)
        {
          g_warning ("%s: %s", G_STRFUNC, error);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]