[glib/gobject-speedups: 12/23] Don't copy values during g_object_set




commit 61aedb1e06dff6b9120177142ca6d33e912f1a67
Author: Matthias Clasen <mclasen redhat com>
Date:   Sun May 15 07:55:22 2022 -0400

    Don't copy values during g_object_set
    
    It should be safe to not copy arguments when
    we are setting properties. This matches what
    we do for g_object_new now.

 gobject/gobject.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
---
diff --git a/gobject/gobject.c b/gobject/gobject.c
index 35ce0a9436..fe7a1ee572 100644
--- a/gobject/gobject.c
+++ b/gobject/gobject.c
@@ -2567,8 +2567,7 @@ g_object_set_valist (GObject       *object,
       if (!g_object_set_is_valid_property (object, pspec, name))
         break;
 
-      G_VALUE_COLLECT_INIT (&value, pspec->value_type, var_args,
-                           0, &error);
+      G_VALUE_COLLECT_INIT (&value, pspec->value_type, var_args, G_VALUE_NOCOPY_CONTENTS, &error);
       if (error)
        {
          g_warning ("%s: %s", G_STRFUNC, error);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]