[epiphany/pgriffis/web-extension-fixes-2: 2/5] web-extensions: Show useful error when icon load fails




commit 90ac0bb6a2c71f98ee1103ca9a49c0f2558a3d67
Author: Patrick Griffis <pgriffis igalia com>
Date:   Mon Apr 25 14:46:24 2022 -0500

    web-extensions: Show useful error when icon load fails

 src/webextension/ephy-web-extension.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/webextension/ephy-web-extension.c b/src/webextension/ephy-web-extension.c
index 6da0035c9..844988670 100644
--- a/src/webextension/ephy-web-extension.c
+++ b/src/webextension/ephy-web-extension.c
@@ -178,7 +178,7 @@ web_extension_icon_new (EphyWebExtension *self,
     if (!self->xpi) {
       g_autofree char *path = NULL;
       path = g_build_filename (self->base_location, file, NULL);
-      pixbuf = gdk_pixbuf_new_from_file (path, NULL);
+      pixbuf = gdk_pixbuf_new_from_file (path, &error);
     }
   } else {
     stream = g_memory_input_stream_new_from_data (data, length, NULL);
@@ -186,7 +186,7 @@ web_extension_icon_new (EphyWebExtension *self,
   }
 
   if (!pixbuf) {
-    g_warning ("Could not read web_extension icon: %s", error ? error->message : "");
+    g_warning ("Could not read web_extension icon (%s): %s", file, error ? error->message : "");
     return NULL;
   }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]