[glib/gobject-speedups: 3/10] Don't inline deprecation warnings




commit 236f625736f2131d04c5c460f4eb0a444372ad31
Author: Matthias Clasen <mclasen redhat com>
Date:   Wed Sep 29 01:38:43 2021 -0400

    Don't inline deprecation warnings
    
    The code that emits property deprecation warnings
    rarely run, and doesn't need to be inlined in all
    our property setters.

 gobject/gobject.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
---
diff --git a/gobject/gobject.c b/gobject/gobject.c
index eb51d44de5..f720e1c9c1 100644
--- a/gobject/gobject.c
+++ b/gobject/gobject.c
@@ -1488,16 +1488,13 @@ g_object_thaw_notify (GObject *object)
 }
 
 static void
-consider_issuing_property_deprecation_warning (const GParamSpec *pspec)
+maybe_issue_property_deprecation_warning (const GParamSpec *pspec)
 {
   static GHashTable *already_warned_table;
   static const gchar *enable_diagnostic;
   static GMutex already_warned_lock;
   gboolean already;
 
-  if (!(pspec->flags & G_PARAM_DEPRECATED))
-    return;
-
   if (g_once_init_enter (&enable_diagnostic))
     {
       const gchar *value = g_getenv ("G_ENABLE_DIAGNOSTIC");
@@ -1537,6 +1534,13 @@ consider_issuing_property_deprecation_warning (const GParamSpec *pspec)
                g_type_name (pspec->owner_type), pspec->name);
 }
 
+static inline void
+consider_issuing_property_deprecation_warning (const GParamSpec *pspec)
+{
+  if (G_UNLIKELY (pspec->flags & G_PARAM_DEPRECATED))
+    maybe_issue_property_deprecation_warning (pspec);
+}
+
 static inline void
 object_get_property (GObject     *object,
                     GParamSpec  *pspec,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]