[glib/gobject-speedups: 13/13] Avoid property notification during g_object_set
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glib/gobject-speedups: 13/13] Avoid property notification during g_object_set
- Date: Sun, 15 May 2022 12:47:12 +0000 (UTC)
commit a92a8041221fcdaf6c565907fa1db995e003750f
Author: Matthias Clasen <mclasen redhat com>
Date: Sun May 15 07:56:43 2022 -0400
Avoid property notification during g_object_set
If we have no nontrivial notify vfunc, and no signal
handlers for notify, we don't need to maintain the
notify queue. No need to notify if nobody's listening.
gobject/gobject.c | 22 ++++++++++++++--------
1 file changed, 14 insertions(+), 8 deletions(-)
---
diff --git a/gobject/gobject.c b/gobject/gobject.c
index 4d6f18204f..8ec8881433 100644
--- a/gobject/gobject.c
+++ b/gobject/gobject.c
@@ -2484,7 +2484,7 @@ g_object_setv (GObject *object,
const GValue values[])
{
guint i;
- GObjectNotifyQueue *nqueue;
+ GObjectNotifyQueue *nqueue = NULL;
GParamSpec *pspec;
GType obj_type;
@@ -2495,7 +2495,10 @@ g_object_setv (GObject *object,
g_object_ref (object);
obj_type = G_OBJECT_TYPE (object);
- nqueue = g_object_notify_queue_freeze (object, FALSE);
+
+ if (_g_object_has_notify_handler (object))
+ nqueue = g_object_notify_queue_freeze (object, FALSE);
+
for (i = 0; i < n_properties; i++)
{
pspec = g_param_spec_pool_lookup (pspec_pool, names[i], obj_type, TRUE);
@@ -2506,7 +2509,8 @@ g_object_setv (GObject *object,
object_set_property (object, pspec, &values[i], nqueue);
}
- g_object_notify_queue_thaw (object, nqueue);
+ if (nqueue)
+ g_object_notify_queue_thaw (object, nqueue);
g_object_unref (object);
}
@@ -2524,13 +2528,13 @@ g_object_set_valist (GObject *object,
const gchar *first_property_name,
va_list var_args)
{
- GObjectNotifyQueue *nqueue;
+ GObjectNotifyQueue *nqueue = NULL;
const gchar *name;
g_return_if_fail (G_IS_OBJECT (object));
-
- g_object_ref (object);
- nqueue = g_object_notify_queue_freeze (object, FALSE);
+
+ if (_g_object_has_notify_handler (object))
+ nqueue = g_object_notify_queue_freeze (object, FALSE);
name = first_property_name;
while (name)
@@ -2562,8 +2566,10 @@ g_object_set_valist (GObject *object,
name = va_arg (var_args, gchar*);
}
- g_object_notify_queue_thaw (object, nqueue);
+ if (nqueue)
+ g_object_notify_queue_thaw (object, nqueue);
g_object_unref (object);
+
}
static inline gboolean
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]