[gtk/matthiasc/color-profile-rebased] gsk: Add FIXME



commit 9e48af467dc48a69913dae64a0699fb3283bdea4
Author: Matthias Clasen <mclasen redhat com>
Date:   Wed May 11 14:54:53 2022 -0400

    gsk: Add FIXME
    
    Point out where we should do colorspace conversion
    in a shader.

 gsk/gl/gskglcommandqueue.c | 2 +-
 gsk/gl/gskgldriver.c       | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
---
diff --git a/gsk/gl/gskglcommandqueue.c b/gsk/gl/gskglcommandqueue.c
index 1454dcd488..1d7a3307fc 100644
--- a/gsk/gl/gskglcommandqueue.c
+++ b/gsk/gl/gskglcommandqueue.c
@@ -1379,7 +1379,7 @@ gsk_gl_command_queue_do_upload_texture (GskGLCommandQueue *self,
     *conversion = GSK_CONVERSION_LINEARIZE;
   else if (data_profile == gdk_color_profile_get_srgb_linear ())
     *conversion = 0;
-  else
+  else /* FIXME: do colorspace conversion in a shader */
     convert_locally = TRUE;
 
   width = gdk_texture_get_width (texture);
diff --git a/gsk/gl/gskgldriver.c b/gsk/gl/gskgldriver.c
index 7dde516fd6..d470cc040a 100644
--- a/gsk/gl/gskgldriver.c
+++ b/gsk/gl/gskgldriver.c
@@ -920,6 +920,7 @@ gsk_gl_driver_load_texture (GskGLDriver *self,
 
               return t->texture_id;
             }
+          /* FIXME: do colorspace conversion in a shader */
         }
     }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]