[gnome-control-center] Address review feedback



commit 861d762ce5c1538fda2167eacf6b8e3fe1a98dbd
Author: Lukáš Tyrychtr <lukastyrychtr gmail com>
Date:   Tue May 10 10:43:50 2022 +0200

    Address review feedback

 panels/network/connection-editor/ce-page-ip4.c | 22 +++++++++++-----------
 panels/network/connection-editor/ce-page-ip6.c |  6 +++---
 panels/network/network-wifi.ui                 |  4 ++--
 3 files changed, 16 insertions(+), 16 deletions(-)
---
diff --git a/panels/network/connection-editor/ce-page-ip4.c b/panels/network/connection-editor/ce-page-ip4.c
index 9ee73d22f..c3f0864d9 100644
--- a/panels/network/connection-editor/ce-page-ip4.c
+++ b/panels/network/connection-editor/ce-page-ip4.c
@@ -40,7 +40,10 @@ struct _CEPageIP4
 {
         AdwBin             parent;
 
+        GtkLabel          *address_address_label;
         GtkBox            *address_box;
+        GtkLabel          *address_gateway_label;
+        GtkLabel          *address_netmask_label;
         GtkSizeGroup      *address_sizegroup;
         GtkSwitch         *auto_dns_switch;
         GtkSwitch         *auto_routes_switch;
@@ -52,15 +55,12 @@ struct _CEPageIP4
         GtkGrid           *main_box;
         GtkCheckButton    *manual_radio;
         GtkCheckButton    *never_default_check;
-        GtkLabel          *address_label;
-        GtkLabel          *netmask_label;
-        GtkLabel          *gateway_label;
-        GtkBox            *routes_box;
         GtkLabel          *routes_address_label;
-        GtkLabel          *routes_netmask_label;
+        GtkBox            *routes_box;
         GtkLabel          *routes_gateway_label;
         GtkLabel          *routes_metric_label;
         GtkSizeGroup      *routes_metric_sizegroup;
+        GtkLabel          *routes_netmask_label;
         GtkSizeGroup      *routes_sizegroup;
         GtkCheckButton    *shared_radio;
 
@@ -226,7 +226,7 @@ add_address_row (CEPageIP4   *self,
         gtk_editable_set_width_chars (GTK_EDITABLE (widget), 16);
         gtk_widget_set_hexpand (widget, TRUE);
         gtk_accessible_update_relation (GTK_ACCESSIBLE (widget),
-                                        GTK_ACCESSIBLE_RELATION_LABELLED_BY, self->address_label, NULL,
+                                        GTK_ACCESSIBLE_RELATION_LABELLED_BY, self->address_address_label, 
NULL,
                                         -1);
         gtk_box_append (GTK_BOX (row_box), widget);
 
@@ -238,7 +238,7 @@ add_address_row (CEPageIP4   *self,
         gtk_editable_set_width_chars (GTK_EDITABLE (widget), 16);
         gtk_widget_set_hexpand (widget, TRUE);
         gtk_accessible_update_relation (GTK_ACCESSIBLE (widget),
-                                        GTK_ACCESSIBLE_RELATION_LABELLED_BY, self->netmask_label, NULL,
+                                        GTK_ACCESSIBLE_RELATION_LABELLED_BY, self->address_netmask_label, 
NULL,
                                         -1);
         gtk_box_append (GTK_BOX (row_box), widget);
 
@@ -250,7 +250,7 @@ add_address_row (CEPageIP4   *self,
         gtk_editable_set_width_chars (GTK_EDITABLE (widget), 16);
         gtk_widget_set_hexpand (widget, TRUE);
         gtk_accessible_update_relation (GTK_ACCESSIBLE (widget),
-                                        GTK_ACCESSIBLE_RELATION_LABELLED_BY, self->gateway_label, NULL,
+                                        GTK_ACCESSIBLE_RELATION_LABELLED_BY, self->address_gateway_label, 
NULL,
                                         -1);
         gtk_box_append (GTK_BOX (row_box), widget);
 
@@ -806,9 +806,9 @@ ce_page_ip4_class_init (CEPageIP4Class *klass)
         gtk_widget_class_bind_template_child (widget_class, CEPageIP4, main_box);
         gtk_widget_class_bind_template_child (widget_class, CEPageIP4, manual_radio);
         gtk_widget_class_bind_template_child (widget_class, CEPageIP4, never_default_check);
-        gtk_widget_class_bind_template_child (widget_class, CEPageIP4, address_label);
-        gtk_widget_class_bind_template_child (widget_class, CEPageIP4, netmask_label);
-        gtk_widget_class_bind_template_child (widget_class, CEPageIP4, gateway_label);
+        gtk_widget_class_bind_template_child (widget_class, CEPageIP4, address_address_label);
+        gtk_widget_class_bind_template_child (widget_class, CEPageIP4, address_netmask_label);
+        gtk_widget_class_bind_template_child (widget_class, CEPageIP4, address_gateway_label);
         gtk_widget_class_bind_template_child (widget_class, CEPageIP4, routes_box);
         gtk_widget_class_bind_template_child (widget_class, CEPageIP4, routes_address_label);
         gtk_widget_class_bind_template_child (widget_class, CEPageIP4, routes_netmask_label);
diff --git a/panels/network/connection-editor/ce-page-ip6.c b/panels/network/connection-editor/ce-page-ip6.c
index 2ff4caf91..09b9eb6f5 100644
--- a/panels/network/connection-editor/ce-page-ip6.c
+++ b/panels/network/connection-editor/ce-page-ip6.c
@@ -41,9 +41,9 @@ struct _CEPageIP6
         AdwBin            parent;
 
         GtkBox            *address_box;
-        GtkLabel         *address_address_label;
-        GtkLabel         *address_prefix_label;
-        GtkLabel         *address_gateway_label;
+        GtkLabel          *address_address_label;
+        GtkLabel          *address_prefix_label;
+        GtkLabel          *address_gateway_label;
         GtkSizeGroup      *address_sizegroup;
         GtkSwitch         *auto_dns_switch;
         GtkSwitch         *auto_routes_switch;
diff --git a/panels/network/network-wifi.ui b/panels/network/network-wifi.ui
index 8203921ed..a88a295ee 100644
--- a/panels/network/network-wifi.ui
+++ b/panels/network/network-wifi.ui
@@ -94,9 +94,9 @@
     <child>
       <object class="GtkMenuButton" id="header_button">
         <property name="popover">header_button_popover</property>
-        <Accessibility>
+        <accessibility>
           <property name="label" translatable="yes">More options…</property>
-        </Accessibility>
+        </accessibility>
         <child>
           <object class="GtkImage">
             <property name="icon_name">view-more-symbolic</property>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]