[extensions-web/wip/ne0sight: 2/4] */*: add a bit more hinting




commit dbd12c14ec6b86344dad713669b2f05a79bef3d8
Author: Yuri Konotopov <ykonotopov gnome org>
Date:   Mon May 9 22:04:53 2022 +0400

    */*: add a bit more hinting

 sweettooth/extensions/models.py | 8 ++++----
 sweettooth/review/views.py      | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)
---
diff --git a/sweettooth/extensions/models.py b/sweettooth/extensions/models.py
index c9b89ad..8a53802 100644
--- a/sweettooth/extensions/models.py
+++ b/sweettooth/extensions/models.py
@@ -10,7 +10,7 @@
     (at your option) any later version.
 """
 
-from typing import Any
+from typing import Any, Literal
 import autoslug
 import json
 import os
@@ -368,8 +368,8 @@ def make_filename(obj, filename=None):
 
 
 class ExtensionVersion(models.Model):
-    extension = models.ForeignKey(Extension, on_delete=models.CASCADE, related_name="versions")
-    version = models.IntegerField(default=0)
+    extension: Extension = models.ForeignKey(Extension, on_delete=models.CASCADE, related_name="versions")
+    version: int = models.IntegerField(default=0)
     extra_json_fields = models.TextField()
     status = models.PositiveIntegerField(choices=STATUSES.items())
     shell_versions = models.ManyToManyField(ShellVersion)
@@ -413,7 +413,7 @@ class ExtensionVersion(models.Model):
     def make_metadata_json_string(self):
         return json.dumps(self.make_metadata_json(), sort_keys=True, indent=2)
 
-    def get_zipfile(self, mode):
+    def get_zipfile(self, mode: Literal["r", "w", "x", "a"]) -> ZipFile:
         return ZipFile(self.source.storage.path(self.source.name), mode)
 
     def replace_metadata_json(self):
diff --git a/sweettooth/review/views.py b/sweettooth/review/views.py
index e6392f9..0068c60 100644
--- a/sweettooth/review/views.py
+++ b/sweettooth/review/views.py
@@ -108,7 +108,7 @@ def get_old_version(version):
 
     return old_version
 
-def get_zipfiles(*args):
+def get_zipfiles(*args: tuple[models.ExtensionVersion]):
     for version in args:
         if version is None:
             yield None
@@ -367,7 +367,7 @@ def should_auto_approve_changeset(changes):
 
     return True
 
-def should_auto_approve(version):
+def should_auto_approve(version: models.ExtensionVersion):
     extension = version.extension
     user = extension.creator
     can_review = can_approve_extension(user, extension)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]