[gnome-control-center/gnome-42] connection-editor: Unparent child widget on dispose
- From: Felipe Borges <felipeborges src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-control-center/gnome-42] connection-editor: Unparent child widget on dispose
- Date: Wed, 4 May 2022 08:30:19 +0000 (UTC)
commit f8a05fe2dc30b0792279b78c11bfc38dceed18d9
Author: Felipe Borges <felipeborges gnome org>
Date: Tue May 3 10:50:33 2022 +0200
connection-editor: Unparent child widget on dispose
WirelessSecurityWPAEAP is a GtkWidget owned by the CEPage8021xSecurity
widget, which is supposed to "unparent" it on "dispose" (since parents
hold a reference to child widgets). Instead we were calling
g_clear_object on it.
Fixes #1671
panels/network/connection-editor/ce-page-8021x-security.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/panels/network/connection-editor/ce-page-8021x-security.c
b/panels/network/connection-editor/ce-page-8021x-security.c
index deec51fc8..90732fa25 100644
--- a/panels/network/connection-editor/ce-page-8021x-security.c
+++ b/panels/network/connection-editor/ce-page-8021x-security.c
@@ -155,7 +155,7 @@ ce_page_8021x_security_dispose (GObject *object)
CEPage8021xSecurity *self = CE_PAGE_8021X_SECURITY (object);
g_clear_object (&self->connection);
- g_clear_object (&self->security);
+ g_clear_pointer ((GtkWidget **) &self->security, gtk_widget_unparent);
g_clear_object (&self->group);
G_OBJECT_CLASS (ce_page_8021x_security_parent_class)->dispose (object);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]