[totem/wip/hadess/fix-search-crash] grilo: Fix crash when scrolling for more content in some cases




commit 0f1022cff10589c7e2c6e355f48166b34e11a5e3
Author: Bastien Nocera <hadess hadess net>
Date:   Tue May 3 17:09:22 2022 +0200

    grilo: Fix crash when scrolling for more content in some cases
    
    When popping down the search entry, and scrolling down to activate the
    "load content" action, we would try and load more search results but we
    never really started a search, leading to a crash.
    
    Make sure that a search is only considered to be started when the search
    entry has been activated.
    
    Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2079657

 src/totem-grilo.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
---
diff --git a/src/totem-grilo.c b/src/totem-grilo.c
index f07cf8d7a..981e07d72 100644
--- a/src/totem-grilo.c
+++ b/src/totem-grilo.c
@@ -1966,6 +1966,8 @@ search_mode_changed (GObject          *gobject,
                        g_assert_not_reached ();
                }
                g_clear_pointer (&self->last_page, g_free);
+
+               self->in_search = search_mode;
        } else {
                GtkTreeModel *model;
                const char *id = NULL;
@@ -2001,7 +2003,6 @@ search_mode_changed (GObject          *gobject,
                gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (self->search_hidden_button), TRUE);
        }
 
-       self->in_search = search_mode;
 }
 
 typedef struct {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]