[gnome-control-center/unparent-ws-wpa-eap-widget] connection-editor: Unparent child widget on dispose




commit 38b0cf84f711655418837ee8efb36336202aae2a
Author: Felipe Borges <felipeborges gnome org>
Date:   Tue May 3 10:50:33 2022 +0200

    connection-editor: Unparent child widget on dispose
    
    WirelessSecurityWPAEAP is a GtkWidget owned by the CEPage8021xSecurity
    widget, which is supposed to "unparent" it on "dispose" (since parents
    hold a reference to child widgets). Instead we were calling
    g_clear_object on it.
    
    Fixes #1671

 panels/network/connection-editor/ce-page-8021x-security.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/panels/network/connection-editor/ce-page-8021x-security.c 
b/panels/network/connection-editor/ce-page-8021x-security.c
index deec51fc8..f0b36e70a 100644
--- a/panels/network/connection-editor/ce-page-8021x-security.c
+++ b/panels/network/connection-editor/ce-page-8021x-security.c
@@ -154,8 +154,8 @@ ce_page_8021x_security_dispose (GObject *object)
 {
        CEPage8021xSecurity *self = CE_PAGE_8021X_SECURITY (object);
 
+        gtk_widget_unparent (GTK_WIDGET (self->security));
         g_clear_object (&self->connection);
-        g_clear_object (&self->security);
         g_clear_object (&self->group);
 
        G_OBJECT_CLASS (ce_page_8021x_security_parent_class)->dispose (object);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]