[totem/wip/hadess/missing-plugins-check: 4/6] backend: Plug memory leaks on exit




commit f0bcd3c6c31ca370a4d7b9e6f055f48942b982ef
Author: Bastien Nocera <hadess hadess net>
Date:   Tue Mar 29 10:09:01 2022 +0200

    backend: Plug memory leaks on exit
    
    A number of variables were not freed when the video widget was
    destroyed.

 src/backend/bacon-video-widget.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
---
diff --git a/src/backend/bacon-video-widget.c b/src/backend/bacon-video-widget.c
index ce88b1a4f..82dd1655a 100644
--- a/src/backend/bacon-video-widget.c
+++ b/src/backend/bacon-video-widget.c
@@ -2450,6 +2450,8 @@ bacon_video_widget_finalize (GObject * object)
   g_clear_pointer (&bvw->referrer, g_free);
   g_clear_pointer (&bvw->mrl, g_free);
   g_clear_pointer (&bvw->subtitle_uri, g_free);
+  g_clear_pointer (&bvw->user_id, g_free);
+  g_clear_pointer (&bvw->user_pw, g_free);
 
   g_clear_object (&bvw->clock);
 
@@ -2467,6 +2469,14 @@ bacon_video_widget_finalize (GObject * object)
     g_list_free_full (bvw->chapters, (GDestroyNotify) gst_mini_object_unref);
     bvw->chapters = NULL;
   }
+  if (bvw->subtitles) {
+    g_list_free_full (bvw->subtitles, (GDestroyNotify) bacon_video_widget_lang_info_free);
+    bvw->subtitles = NULL;
+  }
+  if (bvw->languages) {
+    g_list_free_full (bvw->languages, (GDestroyNotify) bacon_video_widget_lang_info_free);
+    bvw->languages = NULL;
+  }
 
   g_clear_pointer (&bvw->tagcache, gst_tag_list_unref);
   g_clear_pointer (&bvw->audiotags, gst_tag_list_unref);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]