[gnome-software: 1/9] gs-ioprio: Combine helper functions
- From: Milan Crha <mcrha src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software: 1/9] gs-ioprio: Combine helper functions
- Date: Tue, 29 Mar 2022 06:22:30 +0000 (UTC)
commit 9321be3d2860b05537641622755cccd0fbe33d5d
Author: Philip Withnall <pwithnall endlessos org>
Date: Mon Mar 28 15:18:53 2022 +0100
gs-ioprio: Combine helper functions
The body of these functions is identical modulo some parameters. Combine
them.
This introduces no functional changes.
Signed-off-by: Philip Withnall <pwithnall endlessos org>
lib/gs-ioprio.c | 24 +++++-------------------
1 file changed, 5 insertions(+), 19 deletions(-)
---
diff --git a/lib/gs-ioprio.c b/lib/gs-ioprio.c
index 11b9fa673..97f231c63 100644
--- a/lib/gs-ioprio.c
+++ b/lib/gs-ioprio.c
@@ -110,33 +110,19 @@ ioprio_set (int which, int who, int ioprio_val)
}
static int
-set_io_priority_idle (void)
+set_io_priority (int ioprio,
+ int ioclass)
{
- int ioprio, ioclass;
-
- ioprio = 7; /* priority is ignored with idle class */
- ioclass = IOPRIO_CLASS_IDLE << IOPRIO_CLASS_SHIFT;
-
- return ioprio_set (IOPRIO_WHO_PROCESS, 0, ioprio | ioclass);
-}
-
-static int
-set_io_priority_best_effort (int ioprio_val)
-{
- int ioclass;
-
- ioclass = IOPRIO_CLASS_BE << IOPRIO_CLASS_SHIFT;
-
- return ioprio_set (IOPRIO_WHO_PROCESS, 0, ioprio_val | ioclass);
+ return ioprio_set (IOPRIO_WHO_PROCESS, 0, ioprio | (ioclass << IOPRIO_CLASS_SHIFT));
}
void
gs_ioprio_init (void)
{
- if (set_io_priority_idle () == -1) {
+ if (set_io_priority (7, IOPRIO_CLASS_IDLE) == -1) {
g_message ("Could not set idle IO priority, attempting best effort of 7");
- if (set_io_priority_best_effort (7) == -1) {
+ if (set_io_priority (7, IOPRIO_CLASS_BE) == -1) {
g_message ("Could not set best effort IO priority either, giving up");
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]