[libsoup] http2: convert asserts for nghttp2 IO API called from callbacks into warnings



commit 0920964c207985ac1f0d086ec124e9ed9be8a239
Author: Carlos Garcia Campos <cgarcia igalia com>
Date:   Thu Mar 24 14:27:07 2022 +0100

    http2: convert asserts for nghttp2 IO API called from callbacks into warnings
    
    gvfs is hitting those asserts, so somehow we can end up calling nghttp2
    IO functions from the callbacks.

 libsoup/http2/soup-client-message-io-http2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/libsoup/http2/soup-client-message-io-http2.c b/libsoup/http2/soup-client-message-io-http2.c
index 67feb582..0426a142 100644
--- a/libsoup/http2/soup-client-message-io-http2.c
+++ b/libsoup/http2/soup-client-message-io-http2.c
@@ -365,7 +365,7 @@ io_write (SoupClientMessageIOHTTP2 *io,
 
         if (io->write_buffer == NULL) {
                 io->written_bytes = 0;
-                g_assert (io->in_callback == 0);
+                g_warn_if_fail (io->in_callback == 0);
                 io->write_buffer_size = nghttp2_session_mem_send (io->session, (const 
guint8**)&io->write_buffer);
                 NGCHECK (io->write_buffer_size);
                 if (io->write_buffer_size == 0) {
@@ -455,7 +455,7 @@ io_read (SoupClientMessageIOHTTP2  *io,
                                             blocking, cancellable, error)) < 0)
             return FALSE;
 
-        g_assert (io->in_callback == 0);
+        g_warn_if_fail (io->in_callback == 0);
         ret = nghttp2_session_mem_recv (io->session, buffer, read);
         NGCHECK (ret);
         return ret != 0;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]