[gnome-shell/gnome-40] workspacesView: Disable workspace switching while in search
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/gnome-40] workspacesView: Disable workspace switching while in search
- Date: Sun, 20 Mar 2022 20:21:40 +0000 (UTC)
commit 62457bc852f984d309b524a0778acfeb65d22ee1
Author: Sebastian Keller <skeller gnome org>
Date: Sun Feb 20 16:53:43 2022 +0100
workspacesView: Disable workspace switching while in search
WorkspacesDisplay connects to key-press-event on the stage to switch
workspaces when page up or down is pressed and nothing else intercepts
these keys. This means that it is still possible to switch workspaces
while they are hidden behind the search.
So only allow these keybinding while the WorkspacesDisplay is reactive
which gets updated by ControlsManager depending on whether there is an
active search or not. Also set it as initially reactive, because
otherwise the keybindings would only work after performing an initial
search.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2204>
(cherry picked from commit 23047b6d80f06dbc099c1135eb8270cd5443d4e4)
js/ui/workspacesView.js | 4 ++++
1 file changed, 4 insertions(+)
---
diff --git a/js/ui/workspacesView.js b/js/ui/workspacesView.js
index 1d03e31319..3504e7e1f0 100644
--- a/js/ui/workspacesView.js
+++ b/js/ui/workspacesView.js
@@ -836,6 +836,7 @@ class WorkspacesDisplay extends St.Widget {
_init(controls, scrollAdjustment, overviewAdjustment) {
super._init({
layout_manager: new Clutter.BinLayout(),
+ reactive: true,
});
this._controls = controls;
@@ -1153,6 +1154,9 @@ class WorkspacesDisplay extends St.Widget {
if (this._overviewAdjustment.value !== ControlsState.WINDOW_PICKER)
return Clutter.EVENT_PROPAGATE;
+ if (!this.reactive)
+ return Clutter.EVENT_PROPAGATE;
+
const { workspaceManager } = global;
const vertical = workspaceManager.layout_rows === -1;
const rtl = this.get_text_direction() === Clutter.TextDirection.RTL;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]