[gnome-software: 2/4] gs-utils: Add some debug messages for getting/setting ETags

[Philip Withnall <pwithnall src gnome org>]

commit 040e2dca3904d965450158dcdaeedfca12965682
Author: Philip Withnall <pwithnall endlessos org>
Date:   Thu Mar 10 13:27:21 2022 +0000

    gs-utils: Add some debug messages for getting/setting ETags
    
    Signed-off-by: Philip Withnall <pwithnall endlessos org>
    
    Helps: #1677

 lib/gs-utils.c | 28 +++++++++++++++++++++++-----
 1 file changed, 23 insertions(+), 5 deletions(-)
---
diff --git a/lib/gs-utils.c b/lib/gs-utils.c
index 89349b1fe..6dc4d28a0 100644
--- a/lib/gs-utils.c
+++ b/lib/gs-utils.c
@@ -1509,14 +1509,18 @@ gs_utils_get_file_etag (GFile        *file,
                         GCancellable *cancellable)
 {
        g_autoptr(GFileInfo) info = NULL;
+       g_autoptr(GError) local_error = NULL;
 
        g_return_val_if_fail (G_IS_FILE (file), NULL);
        g_return_val_if_fail (cancellable == NULL || G_IS_CANCELLABLE (cancellable), NULL);
 
-       info = g_file_query_info (file, METADATA_ETAG_ATTRIBUTE, G_FILE_QUERY_INFO_NONE, cancellable, NULL);
+       info = g_file_query_info (file, METADATA_ETAG_ATTRIBUTE, G_FILE_QUERY_INFO_NONE, cancellable, 
&local_error);
 
-       if (info == NULL)
+       if (info == NULL) {
+               g_debug ("Error getting attribute ‘%s’ for file ‘%s’: %s",
+                        METADATA_ETAG_ATTRIBUTE, g_file_peek_path (file), local_error->message);
                return NULL;
+       }
 
        return g_strdup (g_file_info_get_attribute_string (info, METADATA_ETAG_ATTRIBUTE));
 }
@@ -1542,15 +1546,29 @@ gs_utils_set_file_etag (GFile        *file,
                         const gchar  *etag,
                         GCancellable *cancellable)
 {
+       g_autoptr(GError) local_error = NULL;
+
        g_return_val_if_fail (G_IS_FILE (file), FALSE);
        g_return_val_if_fail (cancellable == NULL || G_IS_CANCELLABLE (cancellable), FALSE);
 
        if (etag == NULL || *etag == '\0') {
-               return g_file_set_attribute (file, METADATA_ETAG_ATTRIBUTE, G_FILE_ATTRIBUTE_TYPE_INVALID,
-                                            NULL, G_FILE_QUERY_INFO_NONE, cancellable, NULL);
+               if (!g_file_set_attribute (file, METADATA_ETAG_ATTRIBUTE, G_FILE_ATTRIBUTE_TYPE_INVALID,
+                                          NULL, G_FILE_QUERY_INFO_NONE, cancellable, &local_error)) {
+                       g_debug ("Error clearing attribute ‘%s’ on file ‘%s’: %s",
+                                METADATA_ETAG_ATTRIBUTE, g_file_peek_path (file), local_error->message);
+                       return FALSE;
+               }
+
+               return TRUE;
+       }
+
+       if (!g_file_set_attribute_string (file, METADATA_ETAG_ATTRIBUTE, etag, G_FILE_QUERY_INFO_NONE, 
cancellable, &local_error)) {
+               g_debug ("Error setting attribute ‘%s’ to ‘%s’ on file ‘%s’: %s",
+                        METADATA_ETAG_ATTRIBUTE, etag, g_file_peek_path (file), local_error->message);
+               return FALSE;
        }
 
-       return g_file_set_attribute_string (file, METADATA_ETAG_ATTRIBUTE, etag, G_FILE_QUERY_INFO_NONE, 
cancellable, NULL);
+       return TRUE;
 }
 
 /**