[balsa: 1/4] address-book-rubrica: Do not leak strings




commit 1688335705253152c59d7111d26a36c04731c971
Author: Peter Bloomfield <PeterBloomfield bellsouth net>
Date:   Sun Mar 6 11:36:20 2022 -0500

    address-book-rubrica: Do not leak strings
    
    returned by xml_node_get_text().

 libbalsa/address-book-rubrica.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
---
diff --git a/libbalsa/address-book-rubrica.c b/libbalsa/address-book-rubrica.c
index 792cc71a7..3e63bf228 100644
--- a/libbalsa/address-book-rubrica.c
+++ b/libbalsa/address-book-rubrica.c
@@ -640,8 +640,10 @@ extract_data(xmlNodePtr entry, gchar ** first_name, gchar ** last_name,
     }
 
     /* construct first name */
-    if (title)
+    if (title) {
        _first_name = g_string_new(title);
+        g_free(title);
+    }
 
     if (prefix) {
        if (_first_name) {
@@ -649,6 +651,7 @@ extract_data(xmlNodePtr entry, gchar ** first_name, gchar ** last_name,
            _first_name = g_string_append(_first_name, prefix);
        } else
            _first_name = g_string_new(prefix);
+        g_free(prefix);
     }
 
     if (first) {
@@ -657,6 +660,7 @@ extract_data(xmlNodePtr entry, gchar ** first_name, gchar ** last_name,
            _first_name = g_string_append(_first_name, first);
        } else
            _first_name = g_string_new(first);
+        g_free(first);
     }
 
     if (middle) {
@@ -665,6 +669,7 @@ extract_data(xmlNodePtr entry, gchar ** first_name, gchar ** last_name,
            _first_name = g_string_append(_first_name, middle);
        } else
            _first_name = g_string_new(middle);
+        g_free(middle);
     }
 
     if (_first_name)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]