[calls] manager: Remove call-add and call-remove signal

[Evangelos Ribeiro Tzaras <devrtz src gnome org>]

commit 15936253737f2fa9618968b4aa922bad42c5fbff
Author: Evangelos Ribeiro Tzaras <devrtz fortysixandtwo eu>
Date:   Fri Feb 4 04:46:00 2022 +0100

    manager: Remove call-add and call-remove signal
    
    They are phased out in favour of their newly introduced ui-call-* pendants.
    This was done to have a better separation of concerns and allows for some
    cleanup in CallsCall.
    
    Closes #397

 src/calls-manager.c | 32 +-------------------------------
 1 file changed, 1 insertion(+), 31 deletions(-)
---
diff --git a/src/calls-manager.c b/src/calls-manager.c
index 2afd9001..a84b49ee 100644
--- a/src/calls-manager.c
+++ b/src/calls-manager.c
@@ -98,9 +98,7 @@ static GParamSpec *props[PROP_LAST_PROP];
 
 
 enum {
-  SIGNAL_CALL_ADD,
-  SIGNAL_CALL_REMOVE,
-  UI_CALL_ADDDED, /* we're phasing out "call-added" in favour of "ui-call-added" */
+  UI_CALL_ADDDED,
   UI_CALL_REMOVED,
   USSD_ADDED,
   USSD_CANCELLED,
@@ -245,8 +243,6 @@ add_call (CallsManager *self, CallsCall *call, CallsOrigin *origin)
   call_data = calls_ui_call_data_new (call, origin_id);
   g_hash_table_insert (self->calls, call, call_data);
 
-  /* TODO get rid of SIGNAL_CALL_ADD signal */
-  g_signal_emit (self, signals[SIGNAL_CALL_ADD], 0, call, origin);
   g_signal_emit (self, signals[UI_CALL_ADDDED], 0, call_data);
 }
 
@@ -301,10 +297,6 @@ remove_call (CallsManager *self, CallsCall *call, gchar *reason, CallsOrigin *or
   g_timeout_add (DELAY_CALL_REMOVE_MS,
                  G_SOURCE_FUNC (on_remove_delayed),
                  data);
-
-  /* TODO get rid of SIGNAL_CALL_REMOVE signal */
-  /* We ignore the reason for now, because it doesn't give any usefull information */
-  g_signal_emit (self, signals[SIGNAL_CALL_REMOVE], 0, call, origin);
 }
 #undef DELAY_CALL_REMOVE_MS
 
@@ -673,28 +665,6 @@ calls_manager_class_init (CallsManagerClass *klass)
   object_class->get_property = calls_manager_get_property;
   object_class->finalize = calls_manager_finalize;
 
-  signals[SIGNAL_CALL_ADD] =
-   g_signal_new ("call-add",
-                 G_TYPE_FROM_CLASS (klass),
-                 G_SIGNAL_RUN_FIRST,
-                 0,
-                 NULL, NULL, NULL,
-                 G_TYPE_NONE,
-                 2,
-                 CALLS_TYPE_CALL,
-                 CALLS_TYPE_ORIGIN);
-
-  signals[SIGNAL_CALL_REMOVE] =
-   g_signal_new ("call-remove",
-                 G_TYPE_FROM_CLASS (klass),
-                 G_SIGNAL_RUN_FIRST,
-                 0,
-                 NULL, NULL, NULL,
-                 G_TYPE_NONE,
-                 2,
-                 CALLS_TYPE_CALL,
-                 CALLS_TYPE_ORIGIN);
-
   signals[UI_CALL_ADDDED] =
     g_signal_new ("ui-call-added",
                   G_TYPE_FROM_CLASS (klass),