[gnome-software: 2/4] gs-plugin-loader: Avoid a warning about removing a non-existent source




commit 167bbde450c9a34c04a3982fdd3d8cf0c76547a2
Author: Philip Withnall <pwithnall endlessos org>
Date:   Fri Mar 4 14:39:22 2022 +0000

    gs-plugin-loader: Avoid a warning about removing a non-existent source
    
    When running under gdb, the `timeout_id` should be cleared when
    returning `G_SOURCE_REMOVE`, just as it is at the end of the function
    when *not* running under gdb.
    
    This fixes a warning from `g_source_remove()` about an unknown source ID
    when waiting for a long time in gdb.
    
    Signed-off-by: Philip Withnall <pwithnall endlessos org>

 lib/gs-plugin-loader.c | 1 +
 1 file changed, 1 insertion(+)
---
diff --git a/lib/gs-plugin-loader.c b/lib/gs-plugin-loader.c
index 00962691e..6c72bb022 100644
--- a/lib/gs-plugin-loader.c
+++ b/lib/gs-plugin-loader.c
@@ -3529,6 +3529,7 @@ gs_plugin_loader_job_timeout_cb (gpointer user_data)
                         "than %u seconds, as running under gdb",
                         helper->function_name,
                         gs_plugin_job_get_timeout (helper->plugin_job));
+               helper->timeout_id = 0;
                return G_SOURCE_REMOVE;
        }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]