[gnome-software: 27/38] gs-plugin: Drop gs_plugin_set_soup_session()




commit 6de822c28768e289eb2adb5bc159a906684c505e
Author: Philip Withnall <pwithnall endlessos org>
Date:   Sun Feb 20 17:56:49 2022 +0000

    gs-plugin: Drop gs_plugin_set_soup_session()
    
    It’s no longer used. Sessions should be created internally to plugins,
    in the context where they’re needed, using `gs_build_soup_session()`.
    
    Signed-off-by: Philip Withnall <pwithnall endlessos org>
    
    Helps: #1472

 lib/gs-plugin.c | 19 -------------------
 lib/gs-plugin.h |  3 ---
 2 files changed, 22 deletions(-)
---
diff --git a/lib/gs-plugin.c b/lib/gs-plugin.c
index d2bd657ce..23e136d8b 100644
--- a/lib/gs-plugin.c
+++ b/lib/gs-plugin.c
@@ -54,7 +54,6 @@ typedef struct
        GMutex                   cache_mutex;
        GModule                 *module;
        GsPluginFlags            flags;
-       SoupSession             *soup_session;
        GPtrArray               *rules[GS_PLUGIN_RULE_LAST];
        GHashTable              *vfuncs;                /* string:pointer */
        GMutex                   vfuncs_mutex;
@@ -222,8 +221,6 @@ gs_plugin_finalize (GObject *object)
        g_free (priv->name);
        g_free (priv->appstream_id);
        g_free (priv->language);
-       if (priv->soup_session != NULL)
-               g_object_unref (priv->soup_session);
        if (priv->network_monitor != NULL)
                g_object_unref (priv->network_monitor);
        g_hash_table_unref (priv->cache);
@@ -522,22 +519,6 @@ gs_plugin_set_language (GsPlugin *plugin, const gchar *language)
        priv->language = g_strdup (language);
 }
 
-/**
- * gs_plugin_set_soup_session:
- * @plugin: a #GsPlugin
- * @soup_session: a #SoupSession
- *
- * Sets the soup session that this plugin will use when downloading.
- *
- * Since: 3.22
- **/
-void
-gs_plugin_set_soup_session (GsPlugin *plugin, SoupSession *soup_session)
-{
-       GsPluginPrivate *priv = gs_plugin_get_instance_private (plugin);
-       g_set_object (&priv->soup_session, soup_session);
-}
-
 /**
  * gs_plugin_set_network_monitor:
  * @plugin: a #GsPlugin
diff --git a/lib/gs-plugin.h b/lib/gs-plugin.h
index 260696e7b..6ff0ad424 100644
--- a/lib/gs-plugin.h
+++ b/lib/gs-plugin.h
@@ -12,7 +12,6 @@
 #include <glib-object.h>
 #include <gmodule.h>
 #include <gio/gio.h>
-#include <libsoup/soup.h>
 
 #include "gs-app.h"
 #include "gs-app-list.h"
@@ -159,8 +158,6 @@ void                 gs_plugin_remove_flags                 (GsPlugin       *plugin,
                                                         GsPluginFlags   flags);
 guint           gs_plugin_get_scale                    (GsPlugin       *plugin);
 const gchar    *gs_plugin_get_language                 (GsPlugin       *plugin);
-void            gs_plugin_set_soup_session             (GsPlugin       *plugin,
-                                                        SoupSession    *soup_session);
 void            gs_plugin_add_rule                     (GsPlugin       *plugin,
                                                         GsPluginRule    rule,
                                                         const gchar    *name);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]