[balsa] send: Drop unused parameter



commit 089a77a52d1149ffd7cdb4d1e0ed77fc524a7b5a
Author: Peter Bloomfield <PeterBloomfield bellsouth net>
Date:   Thu Mar 3 10:56:22 2022 -0500

    send: Drop unused parameter
    
    The "reply_message" parameter of libbalsa_message_postpone() is unused.
    Remove it, and fix the calls.
    
    When replying to a message, Balsa flags it as "replied" when the reply
    is sent. If the reply is postponed, the reference to the original
    message is dropped, so it cannot be automatically flagged. Hence passing
    a pointer to the original message is pointless.
    
    modified:   libbalsa/send.c
    modified:   libbalsa/send.h
    modified:   src/sendmsg-window.c

 libbalsa/send.c      |  1 -
 libbalsa/send.h      |  1 -
 src/sendmsg-window.c | 14 +++-----------
 3 files changed, 3 insertions(+), 13 deletions(-)
---
diff --git a/libbalsa/send.c b/libbalsa/send.c
index e4a5ef519..ed8eed9f1 100644
--- a/libbalsa/send.c
+++ b/libbalsa/send.c
@@ -1531,7 +1531,6 @@ create_mime_message(LibBalsaMessage *message,
 gboolean
 libbalsa_message_postpone(LibBalsaMessage *message,
                           LibBalsaMailbox *draftbox,
-                          LibBalsaMessage *reply_message,
                           gchar          **extra_headers,
                           gboolean         flow,
                           GError         **error)
diff --git a/libbalsa/send.h b/libbalsa/send.h
index 7c763a4ee..a04af97fa 100644
--- a/libbalsa/send.h
+++ b/libbalsa/send.h
@@ -43,7 +43,6 @@ enum _LibBalsaMsgCreateResult {
 
 gboolean libbalsa_message_postpone(LibBalsaMessage * message,
                                   LibBalsaMailbox * draftbox,
-                                  LibBalsaMessage * reply_message,
                                   gchar ** extra_headers,
                                   gboolean flow, 
                                   GError **error);
diff --git a/src/sendmsg-window.c b/src/sendmsg-window.c
index 4c407e5fc..8e1137bef 100644
--- a/src/sendmsg-window.c
+++ b/src/sendmsg-window.c
@@ -5605,17 +5605,9 @@ message_postpone(BalsaSendmsg * bsmsg)
     g_ptr_array_add(headers, g_strdup_printf("%d", bsmsg->type));
     g_ptr_array_add(headers, NULL);
 
-    if ((bsmsg->type == SEND_REPLY || bsmsg->type == SEND_REPLY_ALL ||
-        bsmsg->type == SEND_REPLY_GROUP))
-       successp = libbalsa_message_postpone(message, balsa_app.draftbox,
-                                             bsmsg->parent_message,
-                                             (gchar **) headers->pdata,
-                                             bsmsg->flow, &error);
-    else
-       successp = libbalsa_message_postpone(message, balsa_app.draftbox,
-                                             NULL,
-                                             (gchar **) headers->pdata,
-                                             bsmsg->flow, &error);
+    successp = libbalsa_message_postpone(message, balsa_app.draftbox,
+                                         (gchar **) headers->pdata,
+                                         bsmsg->flow, &error);
     g_ptr_array_foreach(headers, (GFunc) g_free, NULL);
     g_ptr_array_free(headers, TRUE);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]