[balsa] message: Drop unused parameter



commit 4143313cf160a8b2cd70eea40928cf8fe1e05922
Author: Peter Bloomfield <PeterBloomfield bellsouth net>
Date:   Thu Mar 3 10:44:58 2022 -0500

    message: Drop unused parameter
    
    The "read" parameter of libbalsa_message_body_ref() is unused. Remove
    it, and fix all the calls.
    
    modified:   libbalsa/filter.c
    modified:   libbalsa/mailbox_local.c
    modified:   libbalsa/message.c
    modified:   libbalsa/message.h
    modified:   libbalsa/mime.c
    modified:   libbalsa/send.c
    modified:   src/balsa-message.c
    modified:   src/sendmsg-window.c

 libbalsa/filter.c        | 2 +-
 libbalsa/mailbox_local.c | 2 +-
 libbalsa/message.c       | 1 -
 libbalsa/message.h       | 2 +-
 libbalsa/mime.c          | 2 +-
 libbalsa/send.c          | 2 +-
 src/balsa-message.c      | 4 ++--
 src/sendmsg-window.c     | 6 +++---
 8 files changed, 10 insertions(+), 11 deletions(-)
---
diff --git a/libbalsa/filter.c b/libbalsa/filter.c
index 91ae2be81..2bbc7868a 100644
--- a/libbalsa/filter.c
+++ b/libbalsa/filter.c
@@ -121,7 +121,7 @@ libbalsa_condition_matches(LibBalsaCondition* cond,
              CONDITION_CHKMATCH(cond,CONDITION_MATCH_BODY));
         if(will_ref) {
             gboolean is_refed =
-                libbalsa_message_body_ref(message, FALSE, FALSE);
+                libbalsa_message_body_ref(message, FALSE);
             if (!is_refed) {
                 libbalsa_information(LIBBALSA_INFORMATION_ERROR,
                                      _("Unable to load message body to "
diff --git a/libbalsa/mailbox_local.c b/libbalsa/mailbox_local.c
index f16959bf1..c4e246973 100644
--- a/libbalsa/mailbox_local.c
+++ b/libbalsa/mailbox_local.c
@@ -869,7 +869,7 @@ message_match_real(LibBalsaMailbox *mailbox, guint msgno,
                 message = libbalsa_mailbox_get_message(mailbox, msgno);
             if (!message)
                 return FALSE;
-            is_refed = libbalsa_message_body_ref(message, FALSE, FALSE);
+            is_refed = libbalsa_message_body_ref(message, FALSE);
             if (!is_refed) {
                 libbalsa_information(LIBBALSA_INFORMATION_ERROR,
                                      _("Unable to load message body to "
diff --git a/libbalsa/message.c b/libbalsa/message.c
index 20aa4c0d8..e101117a0 100644
--- a/libbalsa/message.c
+++ b/libbalsa/message.c
@@ -712,7 +712,6 @@ libbalsa_message_reply(LibBalsaMessage *message)
  */
 gboolean
 libbalsa_message_body_ref(LibBalsaMessage *message,
-                          gboolean         read,
                           gboolean         fetch_all_headers)
 {
     LibBalsaFetchFlag flags = 0;
diff --git a/libbalsa/message.h b/libbalsa/message.h
index 48549b7fe..c0a7449ac 100644
--- a/libbalsa/message.h
+++ b/libbalsa/message.h
@@ -199,7 +199,7 @@ void libbalsa_message_reply(LibBalsaMessage * message);
 void libbalsa_message_append_part(LibBalsaMessage * message,
                                  LibBalsaMessageBody * body);
 
-gboolean libbalsa_message_body_ref(LibBalsaMessage * message, gboolean read,
+gboolean libbalsa_message_body_ref(LibBalsaMessage * message,
                                    gboolean fetch_all_headers);
 void libbalsa_message_body_unref(LibBalsaMessage * message);
 
diff --git a/libbalsa/mime.c b/libbalsa/mime.c
index ffa4b92c0..1abf4b18e 100644
--- a/libbalsa/mime.c
+++ b/libbalsa/mime.c
@@ -183,7 +183,7 @@ content2reply(LibBalsaMessageBody * root, gchar * reply_prefix_str,
     LibBalsaMessageBody *body;
     GString *reply = NULL, *res;
 
-    libbalsa_message_body_ref(message, FALSE, FALSE);
+    libbalsa_message_body_ref(message, FALSE);
     for (body = root; body; body = body->next) {
        res = process_mime_part(message, body, reply_prefix_str, llen,
                                 ignore_html, flow);
diff --git a/libbalsa/send.c b/libbalsa/send.c
index 900650224..e4a5ef519 100644
--- a/libbalsa/send.c
+++ b/libbalsa/send.c
@@ -683,7 +683,7 @@ lbs_process_queue_msg(guint                    msgno,
        }
 
        /* check the smtp server */
-       libbalsa_message_body_ref(msg, TRUE, TRUE);
+       libbalsa_message_body_ref(msg, TRUE);
        smtp_server_name = libbalsa_message_get_user_header(msg, "X-Balsa-SmtpServer");
        if (!smtp_server_name) {
                smtp_server_name = libbalsa_smtp_server_get_name(NULL);
diff --git a/src/balsa-message.c b/src/balsa-message.c
index d6b70834a..bb4b090f7 100644
--- a/src/balsa-message.c
+++ b/src/balsa-message.c
@@ -1122,7 +1122,7 @@ balsa_message_set(BalsaMessage * balsa_message, LibBalsaMailbox * mailbox, guint
     }
 
     is_new = LIBBALSA_MESSAGE_IS_UNREAD(message);
-    if(!libbalsa_message_body_ref(message, TRUE, TRUE)) {
+    if(!libbalsa_message_body_ref(message, TRUE)) {
        libbalsa_mailbox_check(mailbox);
         g_object_unref(balsa_message->message);
         balsa_message->message = NULL;
@@ -3220,7 +3220,7 @@ balsa_message_recheck_crypto(BalsaMessage *balsa_message)
     select_part(balsa_message, NULL);
     bm_clear_tree(balsa_message);
 
-    if (!libbalsa_message_body_ref(message, TRUE, TRUE)) {
+    if (!libbalsa_message_body_ref(message, TRUE)) {
        g_object_unref(message);
         return;
     }
diff --git a/src/sendmsg-window.c b/src/sendmsg-window.c
index b021187e9..4c407e5fc 100644
--- a/src/sendmsg-window.c
+++ b/src/sendmsg-window.c
@@ -3481,7 +3481,7 @@ collect_for_quote(BalsaSendmsg        * bsmsg,
         return q_body;
 
     message = root->message;
-    libbalsa_message_body_ref(message, FALSE, FALSE);
+    libbalsa_message_body_ref(message, FALSE);
 
     /* scan the message and collect text parts which might be included
      * in the reply, and if there is only one return this part */
@@ -3685,7 +3685,7 @@ quote_message_body(BalsaSendmsg * bsmsg,
 {
     GString *res;
 
-    if (libbalsa_message_body_ref(message, FALSE, FALSE)) {
+    if (libbalsa_message_body_ref(message, FALSE)) {
         res = quote_body(bsmsg,
                          libbalsa_message_get_headers(message),
                          libbalsa_message_get_message_id(message),
@@ -4352,7 +4352,7 @@ bsm_prepare_for_setup(LibBalsaMessage *message)
         libbalsa_mailbox_open(mailbox, NULL);
     /* fill in that info:
      * ref the message so that we have all needed headers */
-    libbalsa_message_body_ref(message, TRUE, TRUE);
+    libbalsa_message_body_ref(message, TRUE);
     /* scan the message for encrypted parts - this is only possible if
        there is *no* other ref to it */
     balsa_message_perform_crypto(message, LB_MAILBOX_CHK_CRYPT_NEVER,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]