[gnome-software: 1/25] gs-odrs-provider: Remove unreachable return statement




commit 349e79f91557f852ca60ed7ebcc11fb33f8f3226
Author: Philip Withnall <pwithnall endlessos org>
Date:   Wed Feb 23 13:10:22 2022 +0000

    gs-odrs-provider: Remove unreachable return statement
    
    `json_generator_to_data()` can’t fail.
    
    Signed-off-by: Philip Withnall <pwithnall endlessos org>

 lib/gs-odrs-provider.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
---
diff --git a/lib/gs-odrs-provider.c b/lib/gs-odrs-provider.c
index e3bbd53ce..00f3f9737 100644
--- a/lib/gs-odrs-provider.c
+++ b/lib/gs-odrs-provider.c
@@ -776,8 +776,7 @@ gs_odrs_provider_fetch_for_app (GsOdrsProvider  *self,
        json_generator_set_pretty (json_generator, TRUE);
        json_generator_set_root (json_generator, json_root);
        data = json_generator_to_data (json_generator, NULL);
-       if (data == NULL)
-               return NULL;
+
        uri = g_strdup_printf ("%s/fetch", self->review_server);
        g_debug ("Updating ODRS cache for %s from %s to %s; request %s", gs_app_get_id (app),
                 uri, cachefn, data);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]