[epiphany/mcatanzaro/reader-mode-error: 5/5] reader-handler: fix double free of error




commit 4d6819e9382dd799b8379fea8a6f4444e692ead4
Author: Michael Catanzaro <mcatanzaro redhat com>
Date:   Mon Feb 28 12:43:15 2022 -0600

    reader-handler: fix double free of error
    
    When the reader mode JS fails, we accidentally free it manually, even
    though it's stored in an autoptr. Oops!
    
    Fixes #1698, sort of. This really only fixes the Epiphany side of
    things. I will report a separate WebKit bug to ensure the JS execution
    never fails.
    
    Part-of: <https://gitlab.gnome.org/GNOME/epiphany/-/merge_requests/1084>

 embed/ephy-reader-handler.c | 1 -
 1 file changed, 1 deletion(-)
---
diff --git a/embed/ephy-reader-handler.c b/embed/ephy-reader-handler.c
index 304a1854d..aa2c8dfe3 100644
--- a/embed/ephy-reader-handler.c
+++ b/embed/ephy-reader-handler.c
@@ -172,7 +172,6 @@ readability_js_finish_cb (GObject      *object,
   if (!js_result) {
     if (!g_error_matches (error, G_IO_ERROR, G_IO_ERROR_CANCELLED))
       g_warning ("Error running javascript: %s", error->message);
-    g_error_free (error);
     return;
   }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]