[gnome-software/wip/async-plugin-repo-funcs: 28/30] rpm-ostree: Implement repository disable as an async operation
- From: Philip Withnall <pwithnall src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software/wip/async-plugin-repo-funcs: 28/30] rpm-ostree: Implement repository disable as an async operation
- Date: Wed, 29 Jun 2022 10:19:55 +0000 (UTC)
commit 27199b0ad84d37d3f90e8e4708963e5b9c61c7b9
Author: Milan Crha <mcrha redhat com>
Date: Tue Jun 14 18:55:36 2022 +0200
rpm-ostree: Implement repository disable as an async operation
plugins/rpm-ostree/gs-plugin-rpm-ostree.c | 71 +++++++++++++++++++++++++------
1 file changed, 58 insertions(+), 13 deletions(-)
---
diff --git a/plugins/rpm-ostree/gs-plugin-rpm-ostree.c b/plugins/rpm-ostree/gs-plugin-rpm-ostree.c
index 1f894b0bd..d0d4602e6 100644
--- a/plugins/rpm-ostree/gs-plugin-rpm-ostree.c
+++ b/plugins/rpm-ostree/gs-plugin-rpm-ostree.c
@@ -2680,27 +2680,70 @@ gs_plugin_rpm_ostree_enable_repository_finish (GsPlugin *plugin,
return g_task_propagate_boolean (G_TASK (result), error);
}
-gboolean
-gs_plugin_disable_repo (GsPlugin *plugin,
- GsApp *repo,
- GCancellable *cancellable,
- GError **error)
+static void disable_repository_thread_cb (GTask *task,
+ gpointer source_object,
+ gpointer task_data,
+ GCancellable *cancellable);
+
+static void
+gs_plugin_rpm_ostree_disable_repository_async (GsPlugin *plugin,
+ GsApp *repository,
+ GsPluginManageRepositoryFlags flags,
+ GCancellable *cancellable,
+ GAsyncReadyCallback callback,
+ gpointer user_data)
{
GsPluginRpmOstree *self = GS_PLUGIN_RPM_OSTREE (plugin);
+ g_autoptr(GTask) task = NULL;
+ gboolean interactive = (flags & GS_PLUGIN_MANAGE_REPOSITORY_FLAGS_INTERACTIVE);
+
+ task = gs_plugin_manage_repository_data_new_task (plugin, repository, flags, cancellable, callback,
user_data);
+ g_task_set_source_tag (task, gs_plugin_rpm_ostree_disable_repository_async);
+
+ /* only process this app if it was created by this plugin */
+ if (!gs_app_has_management_plugin (repository, plugin)) {
+ g_task_return_boolean (task, TRUE);
+ return;
+ }
+
+ g_assert (gs_app_get_kind (repository) == AS_COMPONENT_KIND_REPOSITORY);
+
+ gs_worker_thread_queue (self->worker, get_priority_for_interactivity (interactive),
+ disable_repository_thread_cb, g_steal_pointer (&task));
+}
+
+/* Run in @worker. */
+static void
+disable_repository_thread_cb (GTask *task,
+ gpointer source_object,
+ gpointer task_data,
+ GCancellable *cancellable)
+{
+ GsPluginRpmOstree *self = GS_PLUGIN_RPM_OSTREE (source_object);
+ GsPluginManageRepositoryData *data = task_data;
g_autoptr(GsRPMOSTreeOS) os_proxy = NULL;
g_autoptr(GsRPMOSTreeSysroot) sysroot_proxy = NULL;
+ g_autoptr(GError) local_error = NULL;
- /* only process this app if it was created by this plugin */
- if (!gs_app_has_management_plugin (repo, plugin))
- return TRUE;
+ assert_in_worker (self);
- /* disable repo */
- g_return_val_if_fail (gs_app_get_kind (repo) == AS_COMPONENT_KIND_REPOSITORY, FALSE);
+ if (!gs_rpmostree_ref_proxies (self, &os_proxy, &sysroot_proxy, cancellable, &local_error)) {
+ g_task_return_error (task, g_steal_pointer (&local_error));
+ return;
+ }
- if (!gs_rpmostree_ref_proxies (self, &os_proxy, &sysroot_proxy, cancellable, error))
- return FALSE;
+ if (gs_rpmostree_repo_enable (GS_PLUGIN (self), data->repository, FALSE, os_proxy, sysroot_proxy,
cancellable, &local_error))
+ g_task_return_boolean (task, TRUE);
+ else
+ g_task_return_error (task, g_steal_pointer (&local_error));
+}
- return gs_rpmostree_repo_enable (plugin, repo, FALSE, os_proxy, sysroot_proxy, cancellable, error);
+static gboolean
+gs_plugin_rpm_ostree_disable_repository_finish (GsPlugin *plugin,
+ GAsyncResult *result,
+ GError **error)
+{
+ return g_task_propagate_boolean (G_TASK (result), error);
}
static void
@@ -2722,6 +2765,8 @@ gs_plugin_rpm_ostree_class_init (GsPluginRpmOstreeClass *klass)
plugin_class->refresh_metadata_finish = gs_plugin_rpm_ostree_refresh_metadata_finish;
plugin_class->enable_repository_async = gs_plugin_rpm_ostree_enable_repository_async;
plugin_class->enable_repository_finish = gs_plugin_rpm_ostree_enable_repository_finish;
+ plugin_class->disable_repository_async = gs_plugin_rpm_ostree_disable_repository_async;
+ plugin_class->disable_repository_finish = gs_plugin_rpm_ostree_disable_repository_finish;
}
GType
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]