[gnome-control-center] network/ce: Provide error tooltip in connection editor
- From: Robert Ancell <rancell src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-control-center] network/ce: Provide error tooltip in connection editor
- Date: Mon, 20 Jun 2022 23:45:20 +0000 (UTC)
commit 0fbe2ada5aec4d6d188038ce514ac57a8a2806cf
Author: Christian Glombek <lorbus fedoraproject org>
Date: Mon Jun 20 13:46:30 2022 +0200
network/ce: Provide error tooltip in connection editor
Pass through localized libnm error messages as tooltips
to the apply button. That way, users can easily identify
configuration errors.
panels/network/connection-editor/net-connection-editor.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
---
diff --git a/panels/network/connection-editor/net-connection-editor.c
b/panels/network/connection-editor/net-connection-editor.c
index ac02a786e..bf623ead3 100644
--- a/panels/network/connection-editor/net-connection-editor.c
+++ b/panels/network/connection-editor/net-connection-editor.c
@@ -343,6 +343,7 @@ static void
validate (NetConnectionEditor *self)
{
gboolean valid = FALSE;
+ g_autofree gchar *apply_tooltip = NULL;
gint i;
if (!editor_is_initialized (self))
@@ -356,15 +357,20 @@ validate (NetConnectionEditor *self)
if (!ce_page_validate (page, self->connection, &error)) {
valid = FALSE;
if (error) {
- g_debug ("Invalid setting %s: %s", ce_page_get_title (page), error->message);
+ apply_tooltip = g_strdup_printf (_("Invalid setting %s: %s"),
ce_page_get_title (page), error->message);
+ g_debug ("%s", apply_tooltip);
} else {
- g_debug ("Invalid setting %s", ce_page_get_title (page));
+ apply_tooltip = g_strdup_printf (_("Invalid setting %s"), ce_page_get_title
(page));
+ g_debug ("%s", apply_tooltip);
}
}
}
update_sensitivity (self);
done:
+ if (apply_tooltip != NULL)
+ gtk_widget_set_tooltip_text(GTK_WIDGET (self->apply_button), apply_tooltip);
+
gtk_widget_set_sensitive (GTK_WIDGET (self->apply_button), valid && self->is_changed);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]