[gnome-control-center] info-overview: change fetch order for consistency
- From: Georges Basile Stavracas Neto <gbsneto src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-control-center] info-overview: change fetch order for consistency
- Date: Fri, 10 Jun 2022 18:07:31 +0000 (UTC)
commit f2f2807e84a730fa0ecc47c7bb931b9a3d6d7543
Author: Amy <apark0006 student cerritos edu>
Date: Sat Jun 4 23:37:52 2022 +0000
info-overview: change fetch order for consistency
Currently, the order in which info_overview_panel_setup_overview fetches
data is essentially random. For ease of maintainability and
understanding, the fetches should be ordered by their appearance as rows
in the panel.
This patch changes the order so that it corresponds with the panel's UI
order.
panels/info-overview/cc-info-overview-panel.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
---
diff --git a/panels/info-overview/cc-info-overview-panel.c b/panels/info-overview/cc-info-overview-panel.c
index d67b5458f..5c6abbff6 100644
--- a/panels/info-overview/cc-info-overview-panel.c
+++ b/panels/info-overview/cc-info-overview-panel.c
@@ -716,7 +716,7 @@ info_overview_panel_setup_overview (CcInfoOverviewPanel *self)
(GAsyncReadyCallback) shell_proxy_ready,
self);
- cc_list_row_set_secondary_label (self->windowing_system_row, get_windowing_system ());
+
get_hardware_model (self);
@@ -731,16 +731,18 @@ info_overview_panel_setup_overview (CcInfoOverviewPanel *self)
cpu_text = get_cpu_info (info);
cc_list_row_set_secondary_markup (self->processor_row, cpu_text);
- os_type_text = get_os_type ();
- cc_list_row_set_secondary_label (self->os_type_row, os_type_text);
+ graphics_hardware_string = get_graphics_hardware_string ();
+ cc_list_row_set_secondary_markup (self->graphics_row, graphics_hardware_string);
+
+ get_primary_disc_info (self);
os_name_text = get_os_name ();
cc_list_row_set_secondary_label (self->os_name_row, os_name_text);
- get_primary_disc_info (self);
+ os_type_text = get_os_type ();
+ cc_list_row_set_secondary_label (self->os_type_row, os_type_text);
- graphics_hardware_string = get_graphics_hardware_string ();
- cc_list_row_set_secondary_markup (self->graphics_row, graphics_hardware_string);
+ cc_list_row_set_secondary_label (self->windowing_system_row, get_windowing_system ());
}
static gboolean
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]