[epiphany/pgriffis/web-extension/tabs: 1/8] ephy_shell_new_tab_full: Support NULL window
- From: Patrick Griffis <pgriffis src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany/pgriffis/web-extension/tabs: 1/8] ephy_shell_new_tab_full: Support NULL window
- Date: Fri, 3 Jun 2022 15:42:04 +0000 (UTC)
commit 2e6a183b66aff123f7d962b8d7ade3a44b0678b5
Author: Patrick Griffis <pgriffis igalia com>
Date: Thu Jun 2 16:05:06 2022 -0500
ephy_shell_new_tab_full: Support NULL window
It is documented supporting NULL but it didn't. Just default to active window.
src/ephy-shell.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
---
diff --git a/src/ephy-shell.c b/src/ephy-shell.c
index c8d95a31c..f319e49b5 100644
--- a/src/ephy-shell.c
+++ b/src/ephy-shell.c
@@ -1026,7 +1026,7 @@ ephy_shell_new_tab_full (EphyShell *shell,
EphyEmbed *parent = NULL;
g_assert (EPHY_IS_SHELL (shell));
- g_assert (EPHY_IS_WINDOW (window));
+ g_assert (EPHY_IS_WINDOW (window) || !window);
g_assert (EPHY_IS_EMBED (previous_embed) || !previous_embed);
embed_shell = EPHY_EMBED_SHELL (shell);
@@ -1034,6 +1034,9 @@ ephy_shell_new_tab_full (EphyShell *shell,
if (flags & EPHY_NEW_TAB_JUMP)
jump_to = TRUE;
+ if (!window)
+ window = EPHY_WINDOW (gtk_application_get_active_window (GTK_APPLICATION (shell)));
+
LOG ("Opening new tab window %p parent-embed %p jump-to:%s",
window, previous_embed, jump_to ? "t" : "f");
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]