[file-roller/wip/jtojnar/engrampa-backports: 6/24] command-dpkg: Fix use after free
- From: Jan Tojnar <jtojnar src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [file-roller/wip/jtojnar/engrampa-backports: 6/24] command-dpkg: Fix use after free
- Date: Wed, 27 Jul 2022 19:54:32 +0000 (UTC)
commit 9b6cc1cc2fb32a326c4e821886ec9fcf07c7e398
Author: rbuj <robert buj gmail com>
Date: Tue Feb 19 19:11:58 2019 +0100
command-dpkg: Fix use after free
$ scan-build ./configure
...
$ scan-build --keep-cc make
...
fr-command-dpkg.c:76:23: warning: Use of memory after it is freed
fdata->name = g_strdup (name);
^~~~~~~~~~~~~~~
...
Cherry-picked from
https://github.com/mate-desktop/engrampa/commit/333a9e9955e964992e209f731f6e33142824e698
src/fr-command-dpkg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/fr-command-dpkg.c b/src/fr-command-dpkg.c
index a7d14897..d8e02cb9 100644
--- a/src/fr-command-dpkg.c
+++ b/src/fr-command-dpkg.c
@@ -71,9 +71,9 @@ process_metadata_line (char *line,
fdata->original_path = fdata->full_path + 1;
g_strfreev (fields);
- g_free (name);
fdata->name = g_strdup (name);
+ g_free (name);
fdata->path = g_strdup ("DEBIAN");
fr_archive_add_file (FR_ARCHIVE (comm), fdata);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]