[tracker/wip/carlosg/bus-fixes: 2/4] libtracker-sparql/bus: Check errors and return values reading cursors




commit 39d54f1c3be2a9b73592c6272e862868dc548d90
Author: Carlos Garnacho <carlosg gnome org>
Date:   Tue Jul 19 18:52:45 2022 +0200

    libtracker-sparql/bus: Check errors and return values reading cursors
    
    Fixes issues reported by Coverity.
    
    CID: #1518981

 src/libtracker-sparql/bus/tracker-bus-cursor.c | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)
---
diff --git a/src/libtracker-sparql/bus/tracker-bus-cursor.c b/src/libtracker-sparql/bus/tracker-bus-cursor.c
index 0dc9282c8..14e8afd13 100644
--- a/src/libtracker-sparql/bus/tracker-bus-cursor.c
+++ b/src/libtracker-sparql/bus/tracker-bus-cursor.c
@@ -210,16 +210,19 @@ tracker_bus_cursor_next (TrackerSparqlCursor  *cursor,
 
        g_clear_pointer (&bus_cursor->types, g_free);
        bus_cursor->types = g_new0 (TrackerSparqlValueType, n_columns);
-       g_input_stream_read_all (G_INPUT_STREAM (bus_cursor->data_stream),
-                                bus_cursor->types,
-                                n_columns * sizeof (gint32),
-                                NULL, NULL, NULL);
+
+       if (!g_input_stream_read_all (G_INPUT_STREAM (bus_cursor->data_stream),
+                                     bus_cursor->types,
+                                     n_columns * sizeof (gint32),
+                                     NULL, NULL, error))
+               return FALSE;
 
        offsets = g_new0 (gint32, n_columns);
-       g_input_stream_read_all (G_INPUT_STREAM (bus_cursor->data_stream),
-                                offsets,
-                                n_columns * sizeof (gint32),
-                                NULL, NULL, NULL);
+       if (!g_input_stream_read_all (G_INPUT_STREAM (bus_cursor->data_stream),
+                                     offsets,
+                                     n_columns * sizeof (gint32),
+                                     NULL, NULL, error))
+               return FALSE;
 
        /* The last offset says how long we have to go to read
         * the whole row data.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]