[gnome-software: 4/11] flatpak: Port gs_plugin_add_categories() vfunc to GsPluginJobListCategories




commit 9ac6c16b51ffa77f7b0803749bd267559dc16c6e
Author: Philip Withnall <pwithnall endlessos org>
Date:   Thu Jul 14 17:13:05 2022 +0100

    flatpak: Port gs_plugin_add_categories() vfunc to GsPluginJobListCategories
    
    Signed-off-by: Philip Withnall <pwithnall endlessos org>
    
    Helps: #1472

 plugins/flatpak/gs-plugin-flatpak.c | 64 +++++++++++++++++++++++++++++++------
 1 file changed, 55 insertions(+), 9 deletions(-)
---
diff --git a/plugins/flatpak/gs-plugin-flatpak.c b/plugins/flatpak/gs-plugin-flatpak.c
index 316d15e3e..45a0c979f 100644
--- a/plugins/flatpak/gs-plugin-flatpak.c
+++ b/plugins/flatpak/gs-plugin-flatpak.c
@@ -1749,21 +1749,65 @@ gs_plugin_file_to_app (GsPlugin *plugin,
        return TRUE;
 }
 
-gboolean
-gs_plugin_add_categories (GsPlugin *plugin,
-                         GPtrArray *list,
-                         GCancellable *cancellable,
-                         GError **error)
+static void refine_categories_thread_cb (GTask        *task,
+                                         gpointer      source_object,
+                                         gpointer      task_data,
+                                         GCancellable *cancellable);
+
+static void
+gs_plugin_flatpak_refine_categories_async (GsPlugin                      *plugin,
+                                           GPtrArray                     *list,
+                                           GsPluginRefineCategoriesFlags  flags,
+                                           GCancellable                  *cancellable,
+                                           GAsyncReadyCallback            callback,
+                                           gpointer                       user_data)
 {
        GsPluginFlatpak *self = GS_PLUGIN_FLATPAK (plugin);
-       gboolean interactive = gs_plugin_has_flags (plugin, GS_PLUGIN_FLAGS_INTERACTIVE);
+       g_autoptr(GTask) task = NULL;
+       gboolean interactive = (flags & GS_PLUGIN_REFINE_CATEGORIES_FLAGS_INTERACTIVE);
+
+       task = gs_plugin_refine_categories_data_new_task (plugin, list, flags,
+                                                         cancellable, callback, user_data);
+       g_task_set_source_tag (task, gs_plugin_flatpak_refine_categories_async);
+
+       /* Queue a job to get the apps. */
+       gs_worker_thread_queue (self->worker, get_priority_for_interactivity (interactive),
+                               refine_categories_thread_cb, g_steal_pointer (&task));
+}
+
+/* Run in @worker. */
+static void
+refine_categories_thread_cb (GTask        *task,
+                             gpointer      source_object,
+                             gpointer      task_data,
+                             GCancellable *cancellable)
+{
+       GsPluginFlatpak *self = GS_PLUGIN_FLATPAK (source_object);
+       g_autoptr(GRWLockReaderLocker) locker = NULL;
+       GsPluginRefineCategoriesData *data = task_data;
+       gboolean interactive = (data->flags & GS_PLUGIN_REFINE_CATEGORIES_FLAGS_INTERACTIVE);
+       g_autoptr(GError) local_error = NULL;
+
+       assert_in_worker (self);
 
        for (guint i = 0; i < self->installations->len; i++) {
                GsFlatpak *flatpak = g_ptr_array_index (self->installations, i);
-               if (!gs_flatpak_add_categories (flatpak, list, interactive, cancellable, error))
-                       return FALSE;
+
+               if (!gs_flatpak_add_categories (flatpak, data->list, interactive, cancellable, &local_error)) 
{
+                       g_task_return_error (task, g_steal_pointer (&local_error));
+                       return;
+               }
        }
-       return TRUE;
+
+       g_task_return_boolean (task, TRUE);
+}
+
+static gboolean
+gs_plugin_flatpak_refine_categories_finish (GsPlugin      *plugin,
+                                            GAsyncResult  *result,
+                                            GError       **error)
+{
+       return g_task_propagate_boolean (G_TASK (result), error);
 }
 
 static void list_apps_thread_cb (GTask        *task,
@@ -2264,6 +2308,8 @@ gs_plugin_flatpak_class_init (GsPluginFlatpakClass *klass)
        plugin_class->enable_repository_finish = gs_plugin_flatpak_enable_repository_finish;
        plugin_class->disable_repository_async = gs_plugin_flatpak_disable_repository_async;
        plugin_class->disable_repository_finish = gs_plugin_flatpak_disable_repository_finish;
+       plugin_class->refine_categories_async = gs_plugin_flatpak_refine_categories_async;
+       plugin_class->refine_categories_finish = gs_plugin_flatpak_refine_categories_finish;
 }
 
 GType


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]