[nautilus/wip/cdavis/post-port-cleanups: 1/6] grid-view: Don't set `focusable`
- From: António Fernandes <antoniof src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [nautilus/wip/cdavis/post-port-cleanups: 1/6] grid-view: Don't set `focusable`
- Date: Sat, 16 Jul 2022 18:56:41 +0000 (UTC)
commit 4cdfa659be71be3bd20323cdc626d38595ceb546
Author: Christopher Davis <christopherdavis gnome org>
Date: Sat Jul 16 08:02:11 2022 -0400
grid-view: Don't set `focusable`
The view can receive focus, which causes it to draw an unnecessary
ring when focused and requires an extra focus step to get into the
items.
The view itself should not be focusable. This was set as a translation
of `can-focus`, but the semantics are different, and you generally
don't want to manually set `focusable` as the widgets set proper
defaults.
src/nautilus-grid-view.c | 1 -
1 file changed, 1 deletion(-)
---
diff --git a/src/nautilus-grid-view.c b/src/nautilus-grid-view.c
index 8a0c8b4f2..b8e0d05f6 100644
--- a/src/nautilus-grid-view.c
+++ b/src/nautilus-grid-view.c
@@ -411,7 +411,6 @@ create_view_ui (NautilusGridView *self)
g_signal_connect (factory, "unbind", G_CALLBACK (unbind_cell), self);
widget = gtk_grid_view_new (GTK_SELECTION_MODEL (model), factory);
- gtk_widget_set_focusable (widget, TRUE);
gtk_widget_set_valign (widget, GTK_ALIGN_START);
/* We don't use the built-in child activation feature for clicks because it
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]