[gtksourceview/gtksourceview-4-8] styles: classic and tango: don't use #rgba colors, use palette's colors
- From: Sébastien Wilmet <swilmet src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtksourceview/gtksourceview-4-8] styles: classic and tango: don't use #rgba colors, use palette's colors
- Date: Thu, 14 Jul 2022 20:46:49 +0000 (UTC)
commit 7942b41c7929a86bf81a4f0bddbf11f6de8d82ef
Author: Sébastien Wilmet <swilmet informatique-libre be>
Date: Wed Jul 13 13:08:14 2022 +0200
styles: classic and tango: don't use #rgba colors, use palette's colors
(1) Don't use rgba with the alpha channel, I think it needs some bug
fixes in the code, see
https://gitlab.gnome.org/GNOME/gtksourceview/-/issues/280
"GSV 4: classic and tango style schemes: bug with gutter's background
color becoming all white"
when several tabs are opened in the text editor.
(2) For the color replacements, in tango use the palette's color (it's a
darker gray, which is easier to distinguish from the main area white
background).
For the "Global Settings", have exactly the same colors between classic
and tango. (The classic palette lacks the aluminium colors).
Fixes https://gitlab.gnome.org/GNOME/gtksourceview/-/issues/280
Closes https://gitlab.gnome.org/GNOME/gtksourceview/-/merge_requests/272
data/styles/classic.xml | 4 ++--
data/styles/tango.xml | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/data/styles/classic.xml b/data/styles/classic.xml
index 183f5881..0a9e1339 100644
--- a/data/styles/classic.xml
+++ b/data/styles/classic.xml
@@ -42,11 +42,11 @@
<color name="purple" value="#A020F0"/>
<!-- Global Settings -->
- <style name="line-numbers" background="#rgba(0,0,0,0.005)"/>
+ <style name="line-numbers" background="#eeeeec"/>
<style name="current-line" background="#eeeeec"/>
<style name="current-line-number" background="#eeeeec"/>
<style name="draw-spaces" foreground="#babdb6"/>
- <style name="background-pattern" background="#rgba(73,74,71,0.1)"/>
+ <style name="background-pattern" background="#f3f3f3"/>
<!-- Bracket Matching -->
<style name="bracket-match" foreground="white" background="gray"/>
diff --git a/data/styles/tango.xml b/data/styles/tango.xml
index 6b272176..049a54fe 100644
--- a/data/styles/tango.xml
+++ b/data/styles/tango.xml
@@ -54,7 +54,7 @@
<color name="aluminium6" value="#2e3436"/>
<!-- Global Settings -->
- <style name="line-numbers" background="#rgba(18,20,21,0.005)"/>
+ <style name="line-numbers" background="aluminium1"/>
<style name="current-line" background="aluminium1"/>
<style name="current-line-number" background="aluminium1"/>
<style name="draw-spaces" foreground="aluminium3"/>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]