[gnome-builder] plugins/stylelint: port to C

[Christian Hergert <chergert src gnome org>]

commit 11e5e60fd1e3b53a27029b610488eaac6d9d90ce
Author: Christian Hergert <chergert redhat com>
Date:   Mon Jul 11 23:18:07 2022 -0700

    plugins/stylelint: port to C

 .../stylelint/gbp-stylelint-diagnostic-provider.c  | 157 +++++++++++++++++++++
 .../stylelint/gbp-stylelint-diagnostic-provider.h  |  31 ++++
 src/plugins/stylelint/meson.build                  |  20 +--
 ...org.gnome.builder.plugins.stylelint.gschema.xml |   9 --
 src/plugins/stylelint/stylelint-plugin.c           |  37 +++++
 src/plugins/stylelint/stylelint.gresource.xml      |   6 +
 src/plugins/stylelint/stylelint.plugin             |  15 +-
 src/plugins/stylelint/stylelint_plugin.py          |  84 -----------
 8 files changed, 248 insertions(+), 111 deletions(-)
---
diff --git a/src/plugins/stylelint/gbp-stylelint-diagnostic-provider.c 
b/src/plugins/stylelint/gbp-stylelint-diagnostic-provider.c
new file mode 100644
index 000000000..e8976a216
--- /dev/null
+++ b/src/plugins/stylelint/gbp-stylelint-diagnostic-provider.c
@@ -0,0 +1,157 @@
+/* gbp-stylelint-diagnostic-provider.c
+ *
+ * Copyright 2021 Jeremy Wilkins <jeb jdwilkins co uk>
+ * Copyright 2022 Veli Tasalı <me velitasali com>
+ * Copyright 2022 Christian Hergert <chergert redhat com>
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * SPDX-License-Identifier: GPL-3.0-or-later
+ */
+
+#define G_LOG_DOMAIN "gbp-stylelint-diagnostic-provider"
+
+#include "config.h"
+
+#include <json-glib/json-glib.h>
+
+#include "gbp-stylelint-diagnostic-provider.h"
+
+struct _GbpStylelintDiagnosticProvider
+{
+  IdeDiagnosticTool parent_instance;
+};
+
+static void
+gbp_stylelint_diagnostic_provider_configure_launcher (IdeDiagnosticTool     *tool,
+                                                      IdeSubprocessLauncher *launcher,
+                                                      GFile                 *file,
+                                                      GBytes                *contents,
+                                                      const char            *language_id)
+{
+  GbpStylelintDiagnosticProvider *self = (GbpStylelintDiagnosticProvider *)tool;
+
+  g_assert (GBP_IS_STYLELINT_DIAGNOSTIC_PROVIDER (self));
+  g_assert (IDE_IS_SUBPROCESS_LAUNCHER (launcher));
+  g_assert (G_IS_FILE (file));
+
+  ide_subprocess_launcher_push_args (launcher, IDE_STRV_INIT ("--formatter", "json"));
+  if (contents != NULL)
+    ide_subprocess_launcher_push_args (launcher, IDE_STRV_INIT ("--stdin", "--stdin-filename"));
+  ide_subprocess_launcher_push_argv (launcher, g_file_peek_path (file));
+}
+
+static IdeDiagnosticSeverity
+parse_severity (const char *str)
+{
+  if (ide_str_equal0 (str, "warning"))
+    return IDE_DIAGNOSTIC_WARNING;
+
+  if (ide_str_equal0 (str, "error"))
+    return IDE_DIAGNOSTIC_ERROR;
+
+  return IDE_DIAGNOSTIC_NOTE;
+}
+
+static void
+gbp_stylelint_diagnostic_provider_populate_diagnostics (IdeDiagnosticTool *tool,
+                                                      IdeDiagnostics    *diagnostics,
+                                                      GFile             *file,
+                                                      const char        *stdout_buf,
+                                                      const char        *stderr_buf)
+{
+  GbpStylelintDiagnosticProvider *self = (GbpStylelintDiagnosticProvider *)tool;
+  g_autoptr(JsonParser) parser = NULL;
+  g_autoptr(GError) error = NULL;
+  JsonNode *root;
+  JsonArray *results;
+
+  g_assert (GBP_IS_STYLELINT_DIAGNOSTIC_PROVIDER (self));
+  g_assert (IDE_IS_DIAGNOSTICS (diagnostics));
+  g_assert (G_IS_FILE (file));
+
+  if (ide_str_empty0 (stdout_buf))
+    return;
+
+  parser = json_parser_new ();
+
+  if (!json_parser_load_from_data (parser, stdout_buf, -1, &error))
+    {
+      g_debug ("%s", error->message);
+      return;
+    }
+
+  if ((root = json_parser_get_root (parser)) &&
+      JSON_NODE_HOLDS_ARRAY (root) &&
+      (results = json_node_get_array (root)))
+    {
+      guint n_results = json_array_get_length (results);
+
+      for (guint r = 0; r < n_results; r++)
+        {
+          JsonObject *result = json_array_get_object_element (results, r);
+          JsonArray *warnings = json_object_get_array_member (result, "warnings");
+          guint n_warnings;
+
+          if (warnings == NULL)
+            continue;
+
+          n_warnings = json_array_get_length (warnings);
+
+          for (guint w = 0; w < n_warnings; w++)
+            {
+              JsonObject *warning = json_array_get_object_element (warnings, w);
+              g_autoptr(IdeDiagnostic) diagnostic = NULL;
+              g_autoptr(IdeLocation) start = NULL;
+              IdeDiagnosticSeverity severity;
+              const char *message;
+              guint start_line;
+              guint start_col;
+
+              if (!json_object_has_member (warning, "line") ||
+                  !json_object_has_member (warning, "column"))
+                continue;
+
+              start_line = MAX (json_object_get_int_member (warning, "line"), 1) - 1;
+              start_col = MAX (json_object_get_int_member (warning, "column"), 1) - 1;
+              start = ide_location_new (file, start_line, start_col);
+              severity = parse_severity (json_object_get_string_member (warning, "severity"));
+              message = json_object_get_string_member (warning, "text");
+
+              diagnostic = ide_diagnostic_new (severity, message, start);
+              ide_diagnostics_add (diagnostics, diagnostic);
+            }
+        }
+    }
+}
+
+G_DEFINE_FINAL_TYPE (GbpStylelintDiagnosticProvider, gbp_stylelint_diagnostic_provider, 
IDE_TYPE_DIAGNOSTIC_TOOL)
+
+static void
+gbp_stylelint_diagnostic_provider_class_init (GbpStylelintDiagnosticProviderClass *klass)
+{
+  IdeDiagnosticToolClass *diagnostic_tool_class = IDE_DIAGNOSTIC_TOOL_CLASS (klass);
+
+  diagnostic_tool_class->configure_launcher = gbp_stylelint_diagnostic_provider_configure_launcher;
+  diagnostic_tool_class->populate_diagnostics = gbp_stylelint_diagnostic_provider_populate_diagnostics;
+}
+
+static void
+gbp_stylelint_diagnostic_provider_init (GbpStylelintDiagnosticProvider *self)
+{
+  g_autofree char *local_program_path = g_build_filename ("node_modules", ".bin", "stylelint", NULL);
+
+  ide_diagnostic_tool_set_program_name (IDE_DIAGNOSTIC_TOOL (self), "stylelint");
+  ide_diagnostic_tool_set_local_program_path (IDE_DIAGNOSTIC_TOOL (self), local_program_path);
+}
diff --git a/src/plugins/stylelint/gbp-stylelint-diagnostic-provider.h 
b/src/plugins/stylelint/gbp-stylelint-diagnostic-provider.h
new file mode 100644
index 000000000..7c7adc5bc
--- /dev/null
+++ b/src/plugins/stylelint/gbp-stylelint-diagnostic-provider.h
@@ -0,0 +1,31 @@
+/* gbp-stylelint-diagnostic-provider.h
+ *
+ * Copyright 2022 Christian Hergert <chergert redhat com>
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * SPDX-License-Identifier: GPL-3.0-or-later
+ */
+
+#pragma once
+
+#include <libide-foundry.h>
+
+G_BEGIN_DECLS
+
+#define GBP_TYPE_STYLELINT_DIAGNOSTIC_PROVIDER (gbp_stylelint_diagnostic_provider_get_type())
+
+G_DECLARE_FINAL_TYPE (GbpStylelintDiagnosticProvider, gbp_stylelint_diagnostic_provider, GBP, 
STYLELINT_DIAGNOSTIC_PROVIDER, IdeDiagnosticTool)
+
+G_END_DECLS
diff --git a/src/plugins/stylelint/meson.build b/src/plugins/stylelint/meson.build
index b437da190..be40ac10c 100644
--- a/src/plugins/stylelint/meson.build
+++ b/src/plugins/stylelint/meson.build
@@ -1,16 +1,16 @@
 if get_option('plugin_stylelint')
 
-install_data('stylelint_plugin.py', install_dir: plugindir)
+plugins_sources += files([
+  'stylelint-plugin.c',
+  'gbp-stylelint-diagnostic-provider.c',
+])
 
-install_data('org.gnome.builder.plugins.stylelint.gschema.xml',
-  install_dir: schema_dir)
-
-configure_file(
-          input: 'stylelint.plugin',
-         output: 'stylelint.plugin',
-  configuration: config_h,
-        install: true,
-    install_dir: plugindir,
+plugin_stylelint_resources = gnome.compile_resources(
+  'stylelint-resources',
+  'stylelint.gresource.xml',
+  c_name: 'gbp_stylelint',
 )
 
+plugins_sources += plugin_stylelint_resources
+
 endif
diff --git a/src/plugins/stylelint/stylelint-plugin.c b/src/plugins/stylelint/stylelint-plugin.c
new file mode 100644
index 000000000..57c53f28c
--- /dev/null
+++ b/src/plugins/stylelint/stylelint-plugin.c
@@ -0,0 +1,37 @@
+/* stylelint-plugin.c
+ *
+ * Copyright 2022 Christian Hergert <chergert redhat com>
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * SPDX-License-Identifier: GPL-3.0-or-later
+ */
+
+#define G_LOG_DOMAIN "stylelint-plugin"
+
+#include "config.h"
+
+#include <libpeas/peas.h>
+
+#include <libide-code.h>
+
+#include "gbp-stylelint-diagnostic-provider.h"
+
+_IDE_EXTERN void
+_gbp_stylelint_register_types (PeasObjectModule *module)
+{
+  peas_object_module_register_extension_type (module,
+                                              IDE_TYPE_DIAGNOSTIC_PROVIDER,
+                                              GBP_TYPE_STYLELINT_DIAGNOSTIC_PROVIDER);
+}
diff --git a/src/plugins/stylelint/stylelint.gresource.xml b/src/plugins/stylelint/stylelint.gresource.xml
new file mode 100644
index 000000000..784842f05
--- /dev/null
+++ b/src/plugins/stylelint/stylelint.gresource.xml
@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<gresources>
+  <gresource prefix="/plugins/stylelint">
+    <file>stylelint.plugin</file>
+  </gresource>
+</gresources>
diff --git a/src/plugins/stylelint/stylelint.plugin b/src/plugins/stylelint/stylelint.plugin
index e28d4d4be..47d01f0c3 100644
--- a/src/plugins/stylelint/stylelint.plugin
+++ b/src/plugins/stylelint/stylelint.plugin
@@ -1,11 +1,10 @@
 [Plugin]
-Authors=Georg Vienna <georg vienna himbarsoft com>, Tobias Schönberg <tobias47n9e gmail com>
-Copyright=Copyright © 2017 Georg Vienna <georg vienna himbarsoft com>, Tobias Schönberg <tobias47n9e gmail 
com>
-Description=Provides stylesheet linting
-Loader=python3
-Hidden=true
-Module=stylelint_plugin
-Name=stylelint
+Authors=Georg Vienna <georg vienna himbarsoft com>, Tobias Schönberg <tobias47n9e gmail com>, Christian 
Hergert <chergert redhat com>
+Copyright=Copyright © 2017 Georg Vienna <georg vienna himbarsoft com>, Tobias Schönberg <tobias47n9e gmail 
com>, Copyright © 2022 Christian Hergert <chergert redhat com>
+Description=Provides linting of CSS, SASS, SCSS, and LESS using the stylelint program
+Embedded=_gbp_stylelint_register_types
+Module=stylelint
+Name=Stylelint
+X-Category=diagnostics
 X-Diagnostic-Provider-Languages=css,scss,sass,less
 X-Diagnostic-Provider-Languages-Priority=100
-X-Builder-ABI=@PACKAGE_ABI@