[gnome-builder/wip/gtk4-port: 1739/1774] libide/foundry: fix some implementation bugs

[Christian Hergert <chergert src gnome org>]

commit 3274e62bf282e81304fc620a972a360201ed5dc0
Author: Christian Hergert <chergert redhat com>
Date:   Thu Jun 30 15:45:04 2022 -0700

    libide/foundry: fix some implementation bugs

 src/libide/foundry/ide-run-commands.c | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)
---
diff --git a/src/libide/foundry/ide-run-commands.c b/src/libide/foundry/ide-run-commands.c
index 2ccbb0ee1..92737f519 100644
--- a/src/libide/foundry/ide-run-commands.c
+++ b/src/libide/foundry/ide-run-commands.c
@@ -114,9 +114,14 @@ ide_run_commands_list_commands_cb (GObject      *object,
   g_assert (IDE_IS_RUN_COMMANDS (self));
 
   if (!(model = ide_run_command_provider_list_commands_finish (provider, result, &error)))
-    g_debug ("Failed to list run commands from %s: %s",
-             G_OBJECT_TYPE_NAME (provider),
-             error->message);
+    {
+      /* Just keep the old one around until things succeed */
+      g_debug ("Failed to list run commands from %s: %s",
+               G_OBJECT_TYPE_NAME (provider), error->message);
+      IDE_EXIT;
+    }
+
+  g_assert (G_IS_LIST_MODEL (model));
 
   /* Try to replace the old item in one-shot if possible */
   if ((old_model = g_hash_table_lookup (self->provider_to_model, provider)) &&
@@ -142,6 +147,8 @@ ide_run_commands_reload_source_func (gpointer data)
   g_assert (IDE_IS_MAIN_THREAD ());
   g_assert (IDE_IS_RUN_COMMANDS (self));
 
+  self->reload_source = 0;
+
   cancellable = ide_object_ref_cancellable (IDE_OBJECT (self));
 
   while ((provider = g_queue_pop_head (&self->invalid)))
@@ -309,7 +316,7 @@ static void
 ide_run_commands_init (IdeRunCommands *self)
 {
   self->provider_to_model = g_hash_table_new_full (NULL, NULL, g_object_unref, g_object_unref);
-  self->models = g_list_store_new (G_TYPE_LIST_STORE);
+  self->models = g_list_store_new (G_TYPE_LIST_MODEL);
   self->flatten_model = gtk_flatten_list_model_new (g_object_ref (G_LIST_MODEL (self->models)));
 
   g_signal_connect_object (self->flatten_model,