[evolution-ews] Remove false runtime check in ews_connection_notification_start_thread()



commit 1763e29441882b70ef671f9709b20a983cfbf459
Author: Milan Crha <mcrha redhat com>
Date:   Mon Jul 11 13:42:50 2022 +0200

    Remove false runtime check in ews_connection_notification_start_thread()
    
    It is false when there are multiple objects sharing the same connection,
    each subscribing to its own folder, then when one is freed it unsubscribes
    from its folder, but the others are still listening for the changes, which
    means the notifications are started again, without freeing the notification
    object in the caller.

 src/EWS/common/e-ews-connection.c | 1 -
 1 file changed, 1 deletion(-)
---
diff --git a/src/EWS/common/e-ews-connection.c b/src/EWS/common/e-ews-connection.c
index 49870fbe..5f02ecca 100644
--- a/src/EWS/common/e-ews-connection.c
+++ b/src/EWS/common/e-ews-connection.c
@@ -7940,7 +7940,6 @@ ews_connection_notification_start_thread (gpointer user_data)
                NOTIFICATION_LOCK (cnc);
 
                if (cnc->priv->subscribed_folders) {
-                       g_warn_if_fail (cnc->priv->notification == NULL);
                        g_clear_object (&cnc->priv->notification);
 
                        cnc->priv->notification = e_ews_notification_new (cnc, last_subscription_id);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]