[ghex] widget: Don't drop additional reference on menu model
- From: Logan Rathbone <larathbone src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [ghex] widget: Don't drop additional reference on menu model
- Date: Fri, 1 Jul 2022 02:41:04 +0000 (UTC)
commit c3dd145b9e2eaee1dc19dc78753f0f8fdcc981f4
Author: Logan Rathbone <poprocks gmail com>
Date: Thu Jun 30 22:26:40 2022 -0400
widget: Don't drop additional reference on menu model
See my closing of: https://gitlab.gnome.org/GNOME/gtk/-/issues/4548
src/gtkhex.c | 5 -----
1 file changed, 5 deletions(-)
---
diff --git a/src/gtkhex.c b/src/gtkhex.c
index a3ed1c6..763c8a4 100644
--- a/src/gtkhex.c
+++ b/src/gtkhex.c
@@ -2564,10 +2564,6 @@ hex_widget_dispose (GObject *object)
g_clear_pointer (&self->scrollbar, gtk_widget_unparent);
g_clear_pointer (&self->busy_spinner, gtk_widget_unparent);
- /* FIXME - This results in assertion errors upon exit. I have been told
- * by ebassi on IRC (16-Dec-2021) that this may be a bug in gtk. See:
- * https://gitlab.gnome.org/GNOME/gtk/-/issues/4548
- */
g_clear_pointer (&self->context_menu, gtk_widget_unparent);
/* Clear pango layouts
@@ -2959,7 +2955,6 @@ hex_widget_init (HexWidget *self)
gtk_widget_set_parent (self->context_menu, widget);
g_object_unref (builder);
- g_object_unref (menu); /* ref'd by gtk_popover_menu_new_from_model */
/* Initialize Adjustment */
self->adj = gtk_adjustment_new (0.0, 0.0, 0.0, 0.0, 0.0, 0.0);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]