[gnome-software: 11/14] gs-plugin-job: Add GS_PLUGIN_JOB_DEDUPE_FLAGS_DEFAULT




commit ae9b05d1a017c9b11a702fae1e105c84ebd3546e
Author: Philip Withnall <pwithnall endlessos org>
Date:   Tue Jan 25 16:29:49 2022 +0000

    gs-plugin-job: Add GS_PLUGIN_JOB_DEDUPE_FLAGS_DEFAULT
    
    This is a more specific name for the set of flags which are typically
    used for deduplicating. It properly reflects their semantics.
    
    Signed-off-by: Philip Withnall <pwithnall endlessos org>
    
    Helps: #1472

 lib/gs-cmd.c                 | 2 +-
 lib/gs-plugin-job.h          | 4 ++++
 plugins/dummy/gs-self-test.c | 2 +-
 3 files changed, 6 insertions(+), 2 deletions(-)
---
diff --git a/lib/gs-cmd.c b/lib/gs-cmd.c
index ea2c5efeb..04716f910 100644
--- a/lib/gs-cmd.c
+++ b/lib/gs-cmd.c
@@ -394,7 +394,7 @@ main (int argc, char **argv)
                        g_autoptr(GsPluginJob) plugin_job = NULL;
                        if (list != NULL)
                                g_object_unref (list);
-                       plugin_job = gs_plugin_job_list_installed_apps_new (self->refine_flags, 
self->max_results, GS_APP_LIST_FILTER_FLAGS_DEFAULT);
+                       plugin_job = gs_plugin_job_list_installed_apps_new (self->refine_flags, 
self->max_results, GS_PLUGIN_JOB_DEDUPE_FLAGS_DEFAULT);
                        list = gs_plugin_loader_job_process (self->plugin_loader, plugin_job,
                                                             NULL, &error);
                        if (list == NULL) {
diff --git a/lib/gs-plugin-job.h b/lib/gs-plugin-job.h
index 376e6c5e9..e6265cec0 100644
--- a/lib/gs-plugin-job.h
+++ b/lib/gs-plugin-job.h
@@ -70,4 +70,8 @@ void           gs_plugin_job_set_review               (GsPluginJob    *self,
 
 #define                 gs_plugin_job_newv(a,...)              
GS_PLUGIN_JOB(g_object_new(GS_TYPE_PLUGIN_JOB, "action", a, __VA_ARGS__))
 
+#define                 GS_PLUGIN_JOB_DEDUPE_FLAGS_DEFAULT     (GS_APP_LIST_FILTER_FLAG_KEY_ID | \
+                                                        GS_APP_LIST_FILTER_FLAG_KEY_SOURCE | \
+                                                        GS_APP_LIST_FILTER_FLAG_KEY_VERSION)
+
 G_END_DECLS
diff --git a/plugins/dummy/gs-self-test.c b/plugins/dummy/gs-self-test.c
index b2009a097..b17809e71 100644
--- a/plugins/dummy/gs-self-test.c
+++ b/plugins/dummy/gs-self-test.c
@@ -357,7 +357,7 @@ gs_plugins_dummy_installed_func (GsPluginLoader *plugin_loader)
                        GS_PLUGIN_REFINE_FLAGS_REQUIRE_CATEGORIES |
                        GS_PLUGIN_REFINE_FLAGS_REQUIRE_PROVENANCE);
 
-       plugin_job = gs_plugin_job_list_installed_apps_new (refine_flags, 0, 
GS_APP_LIST_FILTER_FLAGS_DEFAULT);
+       plugin_job = gs_plugin_job_list_installed_apps_new (refine_flags, 0, 
GS_PLUGIN_JOB_DEDUPE_FLAGS_DEFAULT);
        list = gs_plugin_loader_job_process (plugin_loader, plugin_job, NULL, &error);
        gs_test_flush_main_context ();
        g_assert_no_error (error);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]