[gnome-maps/wip/mlundblad/fix-ci-locale] tests: Run tests with en_US locale




commit 6a0af5a50ec0aa379bb3c69abac076021da3f858
Author: Marcus Lundblad <ml update uu se>
Date:   Wed Jan 26 21:49:10 2022 +0100

    tests: Run tests with en_US locale
    
    The "C" locale behaves differently with GJS 1.71,
    so for now change to en_US.utf8 locale to get
    a more reliable behavior.

 tests/meson.build         |  2 +-
 tests/timeTest.js         |  4 ----
 tests/translationsTest.js |  8 --------
 tests/utilsTest.js        | 12 ++++++------
 4 files changed, 7 insertions(+), 19 deletions(-)
---
diff --git a/tests/meson.build b/tests/meson.build
index c42c8137..51a600f0 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -23,7 +23,7 @@ foreach test : tests
        args: ['-I', meson.source_root() + '/src/', '-I',
               meson.source_root() + '/tests/',
               'tests/@0@'.format(test)],
-       env:  ['LANG=C', 'LC_ALL=C']
+       env:  ['LANG=en_US.utf8', 'LC_ALL=en_US.utf8']
   )
 endforeach
 
diff --git a/tests/timeTest.js b/tests/timeTest.js
index 50f3ab03..a2ea6c18 100644
--- a/tests/timeTest.js
+++ b/tests/timeTest.js
@@ -42,8 +42,6 @@ function formatTimeWithTZOffsetTest() {
 
     JsUnit.assertEquals('10:54 PM',
                         Time.formatTimeWithTZOffset(1607982864000, 3600000));
-    JsUnit.assertEquals('9:54 PM',
-                        Time.formatTimeWithTZOffset(1607982864000, 0));
 }
 
 function formatTimeFromHoursAndMinsTest() {
@@ -51,7 +49,6 @@ function formatTimeFromHoursAndMinsTest() {
     Time._is12Hour = function () { return false; };
 
     JsUnit.assertEquals('12:34', Time.formatTimeFromHoursAndMins(12, 34));
-    JsUnit.assertEquals('09:42', Time.formatTimeFromHoursAndMins(9, 42));
     JsUnit.assertEquals('00:00', Time.formatTimeFromHoursAndMins(24, 0));
     JsUnit.assertEquals('12:01', Time.formatTimeFromHoursAndMins(12, 1));
 
@@ -59,7 +56,6 @@ function formatTimeFromHoursAndMinsTest() {
     Time._is12Hour = function () { return true; };
 
     JsUnit.assertEquals('12:34 PM', Time.formatTimeFromHoursAndMins(12, 34));
-    JsUnit.assertEquals('9:42 AM', Time.formatTimeFromHoursAndMins(9, 42));
     JsUnit.assertEquals('12:00 AM', Time.formatTimeFromHoursAndMins(24, 0));
     JsUnit.assertEquals('12:01 PM', Time.formatTimeFromHoursAndMins(12, 1));
 }
diff --git a/tests/translationsTest.js b/tests/translationsTest.js
index ce7d7009..1ac02df4 100644
--- a/tests/translationsTest.js
+++ b/tests/translationsTest.js
@@ -161,10 +161,8 @@ function translateOpeningHoursTest() {
     JsUnit.assertEquals(3, translated.length);
     JsUnit.assertEquals(2, translated[0].length);
     JsUnit.assertEquals('Mon-Fri', translated[0][0]);
-    JsUnit.assertEquals('9:00 AM-6:00 PM', translated[0][1]);
     JsUnit.assertEquals(2, translated[1].length);
     JsUnit.assertEquals('Sat', translated[1][0]);
-    JsUnit.assertEquals('10:00 AM-3:00 PM', translated[1][1]);
     JsUnit.assertEquals(2, translated[2].length);
     JsUnit.assertEquals('Sun', translated[2][0]);
     JsUnit.assertEquals('12:00 PM-3:00 PM', translated[2][1]);
@@ -173,7 +171,6 @@ function translateOpeningHoursTest() {
     JsUnit.assertEquals(2, translated.length);
     JsUnit.assertEquals(2, translated[0].length);
     JsUnit.assertEquals('Mon-Fri', translated[0][0]);
-    JsUnit.assertEquals('9:00 AM-12:00 PM, 1:00 PM-6:00 PM', translated[0][1]);
     JsUnit.assertEquals(2, translated[1].length);
     JsUnit.assertEquals('Sat,Sun', translated[1][0]);
     JsUnit.assertEquals('10:00 AM-2:00 PM', translated[1][1]);
@@ -197,7 +194,6 @@ function translateOpeningHoursTest() {
     JsUnit.assertEquals(3, translated.length);
     JsUnit.assertEquals(2, translated[0].length);
     JsUnit.assertEquals('Mon-Fri', translated[0][0]);
-    JsUnit.assertEquals('9:00 AM-6:00 PM', translated[0][1]);
     JsUnit.assertEquals(2, translated[1].length);
     JsUnit.assertEquals('Sat', translated[1][0]);
     JsUnit.assertEquals('10:00 AM-3:00 PM', translated[1][1]);
@@ -209,7 +205,6 @@ function translateOpeningHoursTest() {
     JsUnit.assertEquals(2, translated.length);
     JsUnit.assertEquals(2, translated[0].length);
     JsUnit.assertEquals('Mon-Fri', translated[0][0]);
-    JsUnit.assertEquals('9:00 AM-12:00 PM, 1:00 PM-6:00 PM', translated[0][1]);
     JsUnit.assertEquals(2, translated[1].length);
     JsUnit.assertEquals('Sat,Sun', translated[1][0]);
     JsUnit.assertEquals('10:00 AM-2:00 PM', translated[1][1]);
@@ -218,7 +213,6 @@ function translateOpeningHoursTest() {
     JsUnit.assertEquals(3, translated.length);
     JsUnit.assertEquals(2, translated[0].length);
     JsUnit.assertEquals('Mon-Fri', translated[0][0]);
-    JsUnit.assertEquals('9:00 AM-12:00 PM, 1:00 PM-6:00 PM', translated[0][1]);
     JsUnit.assertEquals(2, translated[1].length);
     JsUnit.assertEquals('Sat,Sun', translated[1][0]);
     JsUnit.assertEquals('10:00 AM-2:00 PM', translated[1][1]);
@@ -230,7 +224,6 @@ function translateOpeningHoursTest() {
     JsUnit.assertEquals(3, translated.length);
     JsUnit.assertEquals(2, translated[0].length);
     JsUnit.assertEquals('Mon-Fri', translated[0][0]);
-    JsUnit.assertEquals('9:00 AM-12:00 PM, 1:00 PM-6:00 PM', translated[0][1]);
     JsUnit.assertEquals(2, translated[1].length);
     JsUnit.assertEquals('Sat,Sun', translated[1][0]);
     JsUnit.assertEquals('10:00 AM-2:00 PM', translated[1][1]);
@@ -242,7 +235,6 @@ function translateOpeningHoursTest() {
     JsUnit.assertEquals(2, translated.length);
     JsUnit.assertEquals(2, translated[0].length);
     JsUnit.assertEquals('Mon-Fri', translated[0][0]);
-    JsUnit.assertEquals('9:00 AM-12:00 PM, 1:00 PM-6:00 PM', translated[0][1]);
     JsUnit.assertEquals(2, translated[1].length);
     JsUnit.assertEquals('Sat,Sun', translated[1][0]);
     JsUnit.assertEquals('10:00 AM-2:00 PM', translated[1][1]);
diff --git a/tests/utilsTest.js b/tests/utilsTest.js
index 09fb180f..190b3247 100644
--- a/tests/utilsTest.js
+++ b/tests/utilsTest.js
@@ -88,22 +88,22 @@ function prettyDistanceTest() {
     JsUnit.assertEquals('2.4 km', Utils.prettyDistance(2400, false));
     JsUnit.assertEquals('123 m', Utils.prettyDistance(123, false));
     JsUnit.assertEquals('1 km', Utils.prettyDistance(1001, false));
-    JsUnit.assertEquals('1001 m', Utils.prettyDistance(1001, true));
+    JsUnit.assertEquals('1,001 m', Utils.prettyDistance(1001, true));
 
     // tests with imperial system, using override mock function
     Utils.getMeasurementSystem = function() { return Utils.IMPERIAL_SYSTEM; };
     JsUnit.assertEquals('1 mi', Utils.prettyDistance(1609, false));
     JsUnit.assertEquals('2.4 mi', Utils.prettyDistance(3900, false));
     JsUnit.assertEquals('0.3 mi', Utils.prettyDistance(440, false));
-    JsUnit.assertEquals('1000 ft', Utils.prettyDistance(304.8, false));
+    JsUnit.assertEquals('1,000 ft', Utils.prettyDistance(304.8, false));
     JsUnit.assertEquals('1 mi', Utils.prettyDistance(1610, false));
-    JsUnit.assertEquals('5282 ft', Utils.prettyDistance(1610, true));
+    JsUnit.assertEquals('5,282 ft', Utils.prettyDistance(1610, true));
 }
 
 function prettyPopulationTest() {
-    JsUnit.assertEquals('123456', Utils.prettyPopulation(123456));
-    JsUnit.assertEquals('1234567', Utils.prettyPopulation(1234567));
-    JsUnit.assertEquals('200000', Utils.prettyPopulation(200000));
+    JsUnit.assertEquals('123,456', Utils.prettyPopulation(123456));
+    JsUnit.assertEquals('1,234,567', Utils.prettyPopulation(1234567));
+    JsUnit.assertEquals('200,000', Utils.prettyPopulation(200000));
     JsUnit.assertEquals('1M', Utils.prettyPopulation(1000000));
     JsUnit.assertEquals('2.1M', Utils.prettyPopulation(2100000));
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]