[gnome-software/wip/mcrha/show-metainfo-enh] Apply 4 suggestion(s) to 3 file(s)



commit c89ec06999f2e21043ba2fe27716ffdddcf5b764
Author: Philip Withnall <philip tecnocode co uk>
Date:   Wed Jan 26 09:58:30 2022 +0000

    Apply 4 suggestion(s) to 3 file(s)

 src/gs-details-page.c  | 4 ++--
 src/gs-overview-page.c | 2 +-
 src/gs-shell.c         | 3 +++
 3 files changed, 6 insertions(+), 3 deletions(-)
---
diff --git a/src/gs-details-page.c b/src/gs-details-page.c
index 887822d41..c32bf42f5 100644
--- a/src/gs-details-page.c
+++ b/src/gs-details-page.c
@@ -161,7 +161,7 @@ typedef enum {
 } GsDetailsPageProperty;
 
 static GParamSpec *obj_props[PROP_IS_NARROW + 1] = { NULL, };
-static guint signals [SIGNAL_LAST] = { 0 };
+static guint signals[SIGNAL_LAST] = { 0 };
 
 static GsDetailsPageState
 gs_details_page_get_state (GsDetailsPage *self)
@@ -2207,7 +2207,7 @@ gs_details_page_class_init (GsDetailsPageClass *klass)
        g_object_class_override_property (object_class, PROP_TITLE, "title");
 
        /**
-        * GsDetailsPage:metainfo-loaded:
+        * GsDetailsPage::metainfo-loaded:
         * @app: a #GsApp
         *
         * Emitted after a custom metainfo @app is loaded in the page, but before
diff --git a/src/gs-overview-page.c b/src/gs-overview-page.c
index e257c608e..1af0f264f 100644
--- a/src/gs-overview-page.c
+++ b/src/gs-overview-page.c
@@ -789,7 +789,7 @@ gs_overview_page_new (void)
 }
 
 void
-gs_overview_page_set_featured (GsOverviewPage  *self,
+gs_overview_page_override_featured (GsOverviewPage     *self,
                               GsApp            *app)
 {
        g_autoptr(GsAppList) list = NULL;
diff --git a/src/gs-shell.c b/src/gs-shell.c
index 89b611364..615b4ae59 100644
--- a/src/gs-shell.c
+++ b/src/gs-shell.c
@@ -867,6 +867,9 @@ gs_shell_details_page_metainfo_loaded_cb (GtkWidget *details_page,
        g_return_if_fail (GS_IS_APP (app));
        g_return_if_fail (GS_IS_SHELL (self));
 
+       /* If the user has manually loaded some metainfo to
+        * preview, override the featured carousel with it too,
+        * so they can see how it looks in the carousel. */
        gs_overview_page_set_featured (GS_OVERVIEW_PAGE (self->pages[GS_SHELL_MODE_OVERVIEW]), app);
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]