[libxml2] Fix integer conversion warnings in hash.c

[Nick Wellnhofer <nwellnhof src gnome org>]

commit 67c2e78b810f9d0644f8cbd450527b81821c99bd
Author: Nick Wellnhofer <wellnhofer aevum de>
Date:   Tue Jan 25 02:44:37 2022 +0100

    Fix integer conversion warnings in hash.c
    
    Use unsigned long for temporary variable to avoid integer conversion
    warnings with UBSan.
    
    Note that this does change the computation of hash values for input
    bytes larger than 0x7F. Before, these bytes were first converted to a
    (typically) signed char with a negative value, then to a large unsigned
    long near ULONG_MAX. I doubt that this was intentional. Input bytes
    larger than 0x7F are now converted to unsigned long unchanged.

 hash.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)
---
diff --git a/hash.c b/hash.c
index afa094ef..7b82d2f1 100644
--- a/hash.c
+++ b/hash.c
@@ -86,7 +86,7 @@ static unsigned long
 xmlHashComputeKey(xmlHashTablePtr table, const xmlChar *name,
                  const xmlChar *name2, const xmlChar *name3) {
     unsigned long value = 0L;
-    char ch;
+    unsigned long ch;
 
 #ifdef HASH_RANDOMIZATION
     value = table->random_seed;
@@ -94,19 +94,19 @@ xmlHashComputeKey(xmlHashTablePtr table, const xmlChar *name,
     if (name != NULL) {
        value += 30 * (*name);
        while ((ch = *name++) != 0) {
-           value = value ^ ((value << 5) + (value >> 3) + (unsigned long)ch);
+           value = value ^ ((value << 5) + (value >> 3) + ch);
        }
     }
     value = value ^ ((value << 5) + (value >> 3));
     if (name2 != NULL) {
        while ((ch = *name2++) != 0) {
-           value = value ^ ((value << 5) + (value >> 3) + (unsigned long)ch);
+           value = value ^ ((value << 5) + (value >> 3) + ch);
        }
     }
     value = value ^ ((value << 5) + (value >> 3));
     if (name3 != NULL) {
        while ((ch = *name3++) != 0) {
-           value = value ^ ((value << 5) + (value >> 3) + (unsigned long)ch);
+           value = value ^ ((value << 5) + (value >> 3) + ch);
        }
     }
     return (value % table->size);
@@ -121,7 +121,7 @@ xmlHashComputeQKey(xmlHashTablePtr table,
                   const xmlChar *prefix2, const xmlChar *name2,
                   const xmlChar *prefix3, const xmlChar *name3) {
     unsigned long value = 0L;
-    char ch;
+    unsigned long ch;
 
 #ifdef HASH_RANDOMIZATION
     value = table->random_seed;
@@ -133,37 +133,37 @@ xmlHashComputeQKey(xmlHashTablePtr table,
 
     if (prefix != NULL) {
        while ((ch = *prefix++) != 0) {
-           value = value ^ ((value << 5) + (value >> 3) + (unsigned long)ch);
+           value = value ^ ((value << 5) + (value >> 3) + ch);
        }
        value = value ^ ((value << 5) + (value >> 3) + (unsigned long)':');
     }
     if (name != NULL) {
        while ((ch = *name++) != 0) {
-           value = value ^ ((value << 5) + (value >> 3) + (unsigned long)ch);
+           value = value ^ ((value << 5) + (value >> 3) + ch);
        }
     }
     value = value ^ ((value << 5) + (value >> 3));
     if (prefix2 != NULL) {
        while ((ch = *prefix2++) != 0) {
-           value = value ^ ((value << 5) + (value >> 3) + (unsigned long)ch);
+           value = value ^ ((value << 5) + (value >> 3) + ch);
        }
        value = value ^ ((value << 5) + (value >> 3) + (unsigned long)':');
     }
     if (name2 != NULL) {
        while ((ch = *name2++) != 0) {
-           value = value ^ ((value << 5) + (value >> 3) + (unsigned long)ch);
+           value = value ^ ((value << 5) + (value >> 3) + ch);
        }
     }
     value = value ^ ((value << 5) + (value >> 3));
     if (prefix3 != NULL) {
        while ((ch = *prefix3++) != 0) {
-           value = value ^ ((value << 5) + (value >> 3) + (unsigned long)ch);
+           value = value ^ ((value << 5) + (value >> 3) + ch);
        }
        value = value ^ ((value << 5) + (value >> 3) + (unsigned long)':');
     }
     if (name3 != NULL) {
        while ((ch = *name3++) != 0) {
-           value = value ^ ((value << 5) + (value >> 3) + (unsigned long)ch);
+           value = value ^ ((value << 5) + (value >> 3) + ch);
        }
     }
     return (value % table->size);