[gnome-builder] foundry: fix default install paths



commit dd30dcb535511f3f069d10a5176a3673608fee58
Author: Christian Hergert <chergert redhat com>
Date:   Sun Jan 16 12:20:27 2022 -0800

    foundry: fix default install paths
    
    Avoid things like : in install paths so that we don't risk breaking various
    PATH, GSETTINGS_SCHEMA_DIRS, and other path-like queries.

 src/libide/foundry/ide-runtime.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
---
diff --git a/src/libide/foundry/ide-runtime.c b/src/libide/foundry/ide-runtime.c
index 92935b6a4..a1dd19ca3 100644
--- a/src/libide/foundry/ide-runtime.c
+++ b/src/libide/foundry/ide-runtime.c
@@ -174,16 +174,24 @@ ide_runtime_real_prepare_configuration (IdeRuntime *self,
     {
       g_autofree gchar *install_path = NULL;
       g_autofree gchar *project_id = NULL;
+      g_autofree gchar *id = NULL;
       IdeContext *context;
 
       context = ide_object_get_context (IDE_OBJECT (self));
       project_id = ide_context_dup_project_id (context);
+      id = g_strdup (priv->id);
+
+      /* Make sure we don't have things that can muck up PATH type
+       * environment variables like ":".
+       */
+      g_strdelimit (project_id, "@:/", '-');
+      g_strdelimit (id, "@:/", '-');
 
       install_path = g_build_filename (g_get_user_cache_dir (),
                                        "gnome-builder",
                                        "install",
                                        project_id,
-                                       priv->id,
+                                       id,
                                        NULL);
 
       ide_config_set_prefix (config, install_path);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]