[gnome-clocks] timer-setup: Fix visual issues



commit 7e5df148ad18bcecc1bb89c7fe71c75c7536d959
Author: Maximiliano Sandoval R <msandova gnome org>
Date:   Mon Dec 13 14:00:22 2021 +0100

    timer-setup: Fix visual issues

 data/ui/header-bar.ui     |  1 +
 data/ui/stopwatch-face.ui |  6 ++++--
 data/ui/timer-setup.ui    | 12 ------------
 data/ui/window.ui         |  2 --
 src/window.vala           |  3 ---
 5 files changed, 5 insertions(+), 19 deletions(-)
---
diff --git a/data/ui/header-bar.ui b/data/ui/header-bar.ui
index f1f85784..1a2e2514 100644
--- a/data/ui/header-bar.ui
+++ b/data/ui/header-bar.ui
@@ -24,6 +24,7 @@
           <object class="AdwViewSwitcherTitle" id="view_switcher_title">
             <property name="stack" bind-source="ClocksHeaderBar" bind-property="stack" 
bind-flags="sync-create">ignore-me</property>
             <signal name="notify::title-visible" handler="title_visible_changed"/>
+            <property name="title" translatable="yes">Clocks</property>
           </object>
         </child>
         <child>
diff --git a/data/ui/stopwatch-face.ui b/data/ui/stopwatch-face.ui
index 166b637c..8a5660a2 100644
--- a/data/ui/stopwatch-face.ui
+++ b/data/ui/stopwatch-face.ui
@@ -6,6 +6,7 @@
       <object class="GtkScrolledWindow">
         <property name="min_content_width">300</property>
         <property name="vexpand">True</property>
+        <property name="hscrollbar_policy">never</property>
         <child>
           <object class="AdwClamp">
             <property name="maximum_size">380</property>
@@ -73,9 +74,8 @@
                     </child>
                     <child>
                       <object class="GtkLabel" id="miliseconds_label">
+                        <property name="margin-bottom">4</property>
                         <property name="valign">end</property>
-                        <!-- TODO GTK 4 -->
-                        <!-- <property name="ypad">6</property> -->
                         <property name="label">0</property>
                         <property name="xalign">0</property>
                         <property name="yalign">0</property>
@@ -93,6 +93,8 @@
                 <child>
                   <object class="GtkBox">
                     <property name="spacing">12</property>
+                    <property name="margin-end">18</property>
+                    <property name="margin-start">18</property>
                     <child>
                       <object class="GtkButton" id="start_btn">
                         <property name="label" translatable="yes">_Start</property>
diff --git a/data/ui/timer-setup.ui b/data/ui/timer-setup.ui
index 3ab3ac37..562b619c 100644
--- a/data/ui/timer-setup.ui
+++ b/data/ui/timer-setup.ui
@@ -182,9 +182,6 @@
                     </child>
                     <child>
                       <object class="GtkSpinButton" id="h_spinbutton">
-                        <!-- TODO GTK 4 -->
-                        <!-- <property name="max_length">2</property> -->
-                        <!-- <property name="invisible_char">●</property> -->
                         <property name="width_chars">2</property>
                         <property name="text" translatable="yes">0</property>
                         <property name="xalign">0.5</property>
@@ -196,7 +193,6 @@
                         <signal name="output" handler="show_leading_zeros" swapped="no"/>
                         <style>
                           <class name="clocks-spinbutton"/>
-                          <class name="flat"/>
                         </style>
                         <layout>
                           <property name="column">1</property>
@@ -218,9 +214,6 @@
                     </child>
                     <child>
                       <object class="GtkSpinButton" id="m_spinbutton">
-                        <!-- TODO GTK 4 -->
-                        <!-- <property name="max_length">2</property> -->
-                        <!-- <property name="invisible_char">●</property> -->
                         <property name="width_chars">2</property>
                         <property name="text" translatable="yes">0</property>
                         <property name="xalign">0.5</property>
@@ -233,7 +226,6 @@
                         <signal name="output" handler="show_leading_zeros" swapped="no"/>
                         <style>
                           <class name="clocks-spinbutton"/>
-                          <class name="flat"/>
                         </style>
                         <layout>
                           <property name="column">3</property>
@@ -255,9 +247,6 @@
                     </child>
                     <child>
                       <object class="GtkSpinButton" id="s_spinbutton">
-                        <!-- TODO GTK 4 -->
-                        <!-- <property name="max_length">2</property> -->
-                        <!-- <property name="invisible_char">●</property> -->
                         <property name="width_chars">2</property>
                         <property name="text" translatable="yes">0</property>
                         <property name="xalign">0.5</property>
@@ -270,7 +259,6 @@
                         <signal name="output" handler="show_leading_zeros" swapped="no"/>
                         <style>
                           <class name="clocks-spinbutton"/>
-                          <class name="flat"/>
                         </style>
                         <layout>
                           <property name="column">5</property>
diff --git a/data/ui/window.ui b/data/ui/window.ui
index b191cadd..bca54f85 100644
--- a/data/ui/window.ui
+++ b/data/ui/window.ui
@@ -1,8 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <interface>
   <template class="ClocksWindow" parent="AdwApplicationWindow">
-    <!-- TODO GTK 4 -->
-    <!-- <property name="title" bind-source="header_bar" bind-property="title" bind-flags="sync-create" /> 
-->
     <child>
       <object class="AdwLeaflet" id="alarm_leaflet">
         <property name="orientation">vertical</property>
diff --git a/src/window.vala b/src/window.vala
index 08cb8e72..90b3f84f 100644
--- a/src/window.vala
+++ b/src/window.vala
@@ -104,9 +104,6 @@ public class Window : Adw.ApplicationWindow {
 
         inited = true;
 
-        // TODO GTK 4
-        // header_bar.bind_property ("title", this, "title", SYNC_CREATE);
-
         pane_changed ();
 
         // Setup window geometry saving


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]