GNOME.org
 

[nautilus/wip/antoniof/experimental-gtk4-build: 22/55] general: gtk_widget_show_all() -> gtk_widget_show()


commit fff7b8d9708fd861530d40a82dedc235452317df
Author: António Fernandes <antoniof gnome org>
Date:   Fri Dec 24 00:38:28 2021 +0000

    general: gtk_widget_show_all() -> gtk_widget_show()
    
    All widgets are visible by default. So, there is no need to make
    children visible.

 eel/eel-stock-dialogs.c                                           | 2 +-
 extensions/audio-video-properties/bacon-video-widget-properties.c | 2 +-
 extensions/audio-video-properties/test-properties-page.c          | 2 +-
 extensions/image-properties/nautilus-image-properties-page.c      | 2 +-
 src/nautilus-autorun-software.c                                   | 4 ++--
 src/nautilus-batch-rename-dialog.c                                | 6 +++---
 src/nautilus-compress-dialog-controller.c                         | 2 +-
 src/nautilus-file-operations.c                                    | 4 ++--
 src/nautilus-files-view.c                                         | 4 ++--
 src/nautilus-floating-bar.c                                       | 1 -
 src/nautilus-list-view.c                                          | 2 +-
 src/nautilus-mime-actions.c                                       | 2 +-
 src/nautilus-new-folder-dialog-controller.c                       | 2 +-
 src/nautilus-pathbar.c                                            | 2 +-
 src/nautilus-places-view.c                                        | 2 +-
 src/nautilus-properties-window.c                                  | 4 ++--
 src/nautilus-query-editor.c                                       | 2 +-
 src/nautilus-search-popover.c                                     | 4 ++--
 src/nautilus-toolbar.c                                            | 4 ++--
 src/nautilus-view-icon-controller.c                               | 4 ++--
 20 files changed, 28 insertions(+), 29 deletions(-)
---
diff --git a/eel/eel-stock-dialogs.c b/eel/eel-stock-dialogs.c
index b651bc05a..9844da086 100644
--- a/eel/eel-stock-dialogs.c
+++ b/eel/eel-stock-dialogs.c
@@ -368,7 +368,7 @@ eel_show_simple_dialog (GtkWidget     *parent,
     }
     va_end (button_title_args);
 
-    gtk_widget_show_all (dialog);
+    gtk_widget_show (dialog);
 
     return GTK_DIALOG (dialog);
 }
diff --git a/extensions/audio-video-properties/bacon-video-widget-properties.c 
b/extensions/audio-video-properties/bacon-video-widget-properties.c
index b2b2aaf37..fca9dfd7d 100644
--- a/extensions/audio-video-properties/bacon-video-widget-properties.c
+++ b/extensions/audio-video-properties/bacon-video-widget-properties.c
@@ -276,7 +276,7 @@ bacon_video_widget_properties_new (void)
 
        g_object_unref (group);
 
-       gtk_widget_show_all (GTK_WIDGET (props));
+       gtk_widget_show (GTK_WIDGET (props));
 
        return GTK_WIDGET (props);
 }
diff --git a/extensions/audio-video-properties/test-properties-page.c 
b/extensions/audio-video-properties/test-properties-page.c
index 21be43a34..2e3fa6678 100644
--- a/extensions/audio-video-properties/test-properties-page.c
+++ b/extensions/audio-video-properties/test-properties-page.c
@@ -38,7 +38,7 @@ create_props (const char *url)
        props = totem_properties_view_new (url, label);
        gtk_container_add (GTK_CONTAINER (window), props);
 
-       gtk_widget_show_all (window);
+       gtk_widget_show (window);
 }
 
 static void
diff --git a/extensions/image-properties/nautilus-image-properties-page.c 
b/extensions/image-properties/nautilus-image-properties-page.c
index 86d4ce9cd..722215d61 100644
--- a/extensions/image-properties/nautilus-image-properties-page.c
+++ b/extensions/image-properties/nautilus-image-properties-page.c
@@ -117,7 +117,7 @@ nautilus_image_properties_page_init (NautilusImagesPropertiesPage *self)
                                    self->grid);
 #endif
 
-    gtk_widget_show_all (GTK_WIDGET (self->page_widget));
+    gtk_widget_show (GTK_WIDGET (self->page_widget));
 }
 
 static void
diff --git a/src/nautilus-autorun-software.c b/src/nautilus-autorun-software.c
index 7a000f6f0..e98ceebf6 100644
--- a/src/nautilus-autorun-software.c
+++ b/src/nautilus-autorun-software.c
@@ -162,7 +162,7 @@ out:
                           G_CALLBACK (gtk_window_destroy),
                           NULL);
 
-        gtk_widget_show_all (dialog);
+        gtk_widget_show (dialog);
     }
 }
 
@@ -236,7 +236,7 @@ present_autorun_for_software_dialog (GMount *mount)
                       G_CALLBACK (autorun_software_dialog_response),
                       mount);
 
-    gtk_widget_show_all (dialog);
+    gtk_widget_show (dialog);
 }
 
 int
diff --git a/src/nautilus-batch-rename-dialog.c b/src/nautilus-batch-rename-dialog.c
index fe8b75017..097f89207 100644
--- a/src/nautilus-batch-rename-dialog.c
+++ b/src/nautilus-batch-rename-dialog.c
@@ -582,7 +582,7 @@ create_original_name_label (NautilusBatchRenameDialog *dialog,
 
     dialog->listbox_labels_old = g_list_prepend (dialog->listbox_labels_old, label_old);
 
-    gtk_widget_show_all (label_old);
+    gtk_widget_show (label_old);
 
     return label_old;
 }
@@ -601,7 +601,7 @@ create_result_label (NautilusBatchRenameDialog *dialog,
 
     dialog->listbox_labels_new = g_list_prepend (dialog->listbox_labels_new, label_new);
 
-    gtk_widget_show_all (label_new);
+    gtk_widget_show (label_new);
 
     return label_new;
 }
@@ -627,7 +627,7 @@ create_arrow (NautilusBatchRenameDialog *dialog,
 
     dialog->listbox_icons = g_list_prepend (dialog->listbox_icons, icon);
 
-    gtk_widget_show_all (icon);
+    gtk_widget_show (icon);
 
     return icon;
 }
diff --git a/src/nautilus-compress-dialog-controller.c b/src/nautilus-compress-dialog-controller.c
index dd188b4f3..0d32525d7 100644
--- a/src/nautilus-compress-dialog-controller.c
+++ b/src/nautilus-compress-dialog-controller.c
@@ -511,7 +511,7 @@ nautilus_compress_dialog_controller_new (GtkWindow         *parent_window,
         gtk_editable_set_text (GTK_EDITABLE (name_entry), initial_name);
     }
 
-    gtk_widget_show_all (compress_dialog);
+    gtk_widget_show (compress_dialog);
 
     update_selected_format (self, format);
 
diff --git a/src/nautilus-file-operations.c b/src/nautilus-file-operations.c
index 0421ec052..a408662c8 100644
--- a/src/nautilus-file-operations.c
+++ b/src/nautilus-file-operations.c
@@ -1430,7 +1430,7 @@ do_run_simple_dialog (gpointer _data)
 
     /* Run it. */
     g_signal_connect (dialog, "response", G_CALLBACK (simple_dialog_cb), data);
-    gtk_widget_show_all (dialog);
+    gtk_widget_show (dialog);
 
     return FALSE;
 }
@@ -3115,7 +3115,7 @@ nautilus_file_operations_unmount_mount_full (GtkWindow               *parent_win
         dialog = create_empty_trash_prompt (parent_window);
 
         g_signal_connect (dialog, "response", G_CALLBACK (empty_trash_prompt_cb), data);
-        gtk_widget_show_all (dialog);
+        gtk_widget_show (dialog);
         return;
     }
 
diff --git a/src/nautilus-files-view.c b/src/nautilus-files-view.c
index 76fb7cf26..410fea7d1 100644
--- a/src/nautilus-files-view.c
+++ b/src/nautilus-files-view.c
@@ -5928,7 +5928,7 @@ copy_or_move_selection (NautilusFilesView *view,
                       G_CALLBACK (on_destination_dialog_response),
                       copy_data);
 
-    gtk_widget_show_all (dialog);
+    gtk_widget_show (dialog);
 }
 
 static void
@@ -6383,7 +6383,7 @@ extract_files_to_chosen_location (NautilusFilesView *view,
                       G_CALLBACK (on_extract_destination_dialog_response),
                       data);
 
-    gtk_widget_show_all (dialog);
+    gtk_widget_show (dialog);
 }
 
 static void
diff --git a/src/nautilus-floating-bar.c b/src/nautilus-floating-bar.c
index 55a35f744..1dd33b25b 100644
--- a/src/nautilus-floating-bar.c
+++ b/src/nautilus-floating-bar.c
@@ -397,7 +397,6 @@ nautilus_floating_bar_constructed (GObject *obj)
     gtk_box_append (GTK_BOX (self), w);
     self->stop_button = w;
     gtk_widget_set_visible (w, FALSE);
-    gtk_widget_set_no_show_all (w, TRUE);
 
     g_signal_connect (self->stop_button, "clicked",
                       G_CALLBACK (stop_button_clicked_cb), self);
diff --git a/src/nautilus-list-view.c b/src/nautilus-list-view.c
index ae486a326..f10c9b80e 100644
--- a/src/nautilus-list-view.c
+++ b/src/nautilus-list-view.c
@@ -1467,7 +1467,7 @@ popup_column_header_menu (NautilusListView *list_view,
                       G_CALLBACK (column_header_menu_use_default),
                       list_view);
 
-    gtk_widget_show_all (menu);
+    gtk_widget_show (menu);
     gtk_popover_set_pointing_to (popover, &(GdkRectangle){x, y, 0, 0});
     gtk_popover_popup (popover);
 
diff --git a/src/nautilus-mime-actions.c b/src/nautilus-mime-actions.c
index 7a88865f4..923cab933 100644
--- a/src/nautilus-mime-actions.c
+++ b/src/nautilus-mime-actions.c
@@ -1377,7 +1377,7 @@ pk_proxy_appeared_cb (GObject      *source,
     g_signal_connect (dialog, "response",
                       G_CALLBACK (application_unhandled_file_install),
                       parameters_install);
-    gtk_widget_show_all (dialog);
+    gtk_widget_show (dialog);
     g_free (mime_type);
 }
 
diff --git a/src/nautilus-new-folder-dialog-controller.c b/src/nautilus-new-folder-dialog-controller.c
index 0b47ef478..9638c8787 100644
--- a/src/nautilus-new-folder-dialog-controller.c
+++ b/src/nautilus-new-folder-dialog-controller.c
@@ -146,7 +146,7 @@ nautilus_new_folder_dialog_controller_new (GtkWindow         *parent_window,
     gtk_label_set_text (GTK_LABEL (name_label), _("Folder name"));
     gtk_window_set_title (GTK_WINDOW (new_folder_dialog), _("New Folder"));
 
-    gtk_widget_show_all (new_folder_dialog);
+    gtk_widget_show (new_folder_dialog);
 
     return self;
 }
diff --git a/src/nautilus-pathbar.c b/src/nautilus-pathbar.c
index 2a5002fab..db294c2c1 100644
--- a/src/nautilus-pathbar.c
+++ b/src/nautilus-pathbar.c
@@ -1079,7 +1079,7 @@ make_button_data (NautilusPathBar *self,
     }
 
     gtk_button_set_child (GTK_BUTTON (button_data->button), child);
-    gtk_widget_show_all (button_data->container);
+    gtk_widget_show (button_data->container);
 
     nautilus_path_bar_update_button_state (button_data, current_dir);
 
diff --git a/src/nautilus-places-view.c b/src/nautilus-places-view.c
index 45e69dbf4..a704c4e33 100644
--- a/src/nautilus-places-view.c
+++ b/src/nautilus-places-view.c
@@ -136,7 +136,7 @@ show_error_message_cb (NautilusGtkPlacesView *view,
                                               "%s", secondary);
 
     g_signal_connect (dialog, "response", G_CALLBACK (gtk_window_destroy), NULL);
-    gtk_widget_show_all (dialog);
+    gtk_widget_show (dialog);
 }
 
 static void
diff --git a/src/nautilus-properties-window.c b/src/nautilus-properties-window.c
index 6b47a076b..4bd3c8675 100644
--- a/src/nautilus-properties-window.c
+++ b/src/nautilus-properties-window.c
@@ -4132,7 +4132,7 @@ on_change_permissions_clicked (GtkWidget                *button,
     set_active_from_umask (combo, PERMISSION_OTHER, TRUE);
 
     g_signal_connect (dialog, "response", G_CALLBACK (on_change_permissions_response), self);
-    gtk_widget_show_all (dialog);
+    gtk_widget_show (dialog);
 }
 
 static void
@@ -4172,7 +4172,7 @@ setup_permissions_page (NautilusPropertiesWindow *self)
 
         if (self->has_recursive_apply)
         {
-            gtk_widget_show_all (self->change_permissions_button_box);
+            gtk_widget_show (self->change_permissions_button_box);
             g_signal_connect (self->change_permissions_button, "clicked",
                               G_CALLBACK (on_change_permissions_clicked),
                               self);
diff --git a/src/nautilus-query-editor.c b/src/nautilus-query-editor.c
index d073aa815..8b2549ea6 100644
--- a/src/nautilus-query-editor.c
+++ b/src/nautilus-query-editor.c
@@ -636,7 +636,7 @@ setup_widgets (NautilusQueryEditor *editor)
                       G_CALLBACK (search_popover_fts_changed_cb), editor);
 
     /* show everything */
-    gtk_widget_show_all (vbox);
+    gtk_widget_show (vbox);
 }
 
 static void
diff --git a/src/nautilus-search-popover.c b/src/nautilus-search-popover.c
index bab56ddca..e19dacda5 100644
--- a/src/nautilus-search-popover.c
+++ b/src/nautilus-search-popover.c
@@ -406,7 +406,7 @@ create_row_for_label (const gchar *text,
                           NULL);
 
     gtk_list_box_row_set_child (GTK_LIST_BOX_ROW (row), label);
-    gtk_widget_show_all (row);
+    gtk_widget_show (row);
 
     return row;
 }
@@ -654,7 +654,7 @@ show_other_types_dialog (NautilusSearchPopover *popover)
     popover->treeview = GTK_TREE_VIEW (g_object_ref (treeview));
 
     g_signal_connect (dialog, "response", G_CALLBACK (on_other_types_dialog_response), popover);
-    gtk_widget_show_all (dialog);
+    gtk_widget_show (dialog);
 }
 
 static void
diff --git a/src/nautilus-toolbar.c b/src/nautilus-toolbar.c
index de9e53a75..5df687cc0 100644
--- a/src/nautilus-toolbar.c
+++ b/src/nautilus-toolbar.c
@@ -783,7 +783,7 @@ operations_list_create_widget (GObject  *item,
     GtkWidget *widget;
 
     widget = nautilus_progress_info_widget_new (info);
-    gtk_widget_show_all (widget);
+    gtk_widget_show (widget);
 
     return widget;
 }
@@ -860,7 +860,7 @@ nautilus_toolbar_constructed (GObject *object)
      * the whole title widget. */
     gtk_editable_set_max_width_chars (GTK_EDITABLE (self->location_entry), 88);
 
-    gtk_widget_show_all (GTK_WIDGET (self));
+    gtk_widget_show (GTK_WIDGET (self));
     toolbar_update_appearance (self);
 }
 
diff --git a/src/nautilus-view-icon-controller.c b/src/nautilus-view-icon-controller.c
index ac90d95cb..47998774e 100644
--- a/src/nautilus-view-icon-controller.c
+++ b/src/nautilus-view-icon-controller.c
@@ -1305,7 +1305,7 @@ setup_item_ui (GtkWidget **child,
     nautilus_view_item_ui_set_caption_attributes (item_ui, self->caption_attributes);
 
     *child = GTK_WIDGET (item_ui);
-    gtk_widget_show_all (*child);
+    gtk_widget_show (*child);
 }
 
 static GtkWidget *
@@ -1415,7 +1415,7 @@ constructed (GObject *object)
                                      G_N_ELEMENTS (view_icon_actions),
                                      self);
 
-    gtk_widget_show_all (GTK_WIDGET (self));
+    gtk_widget_show (GTK_WIDGET (self));
 
     view_action_group = nautilus_files_view_get_action_group (NAUTILUS_FILES_VIEW (self));
     g_action_map_add_action_entries (G_ACTION_MAP (view_action_group),
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]